Merge pull request #417 from bkreitch/check-genmanifest-error

databus23 · web-flow · commit 704355faddeb · 2022-12-09T14:04:43.000+01:00
Check the error returned by genManifest
diff --git a/cmd/upgrade.go b/cmd/upgrade.go
@@ -257,6 +257,9 @@ func (d *diffCmd) runHelm3() error {
 			return errors.Wrap(err, "unable to build kubernetes objects from new release manifest")
 		}
 		releaseManifest, installManifest, err = genManifest(original, target)
+		if err != nil {
+			return errors.Wrap(err, "unable to generate manifests")
+		}
 	}
 
 	currentSpecs := make(map[string]*manifest.MappingResult)

Original file line number	Diff line number	Diff line change
`@@ -257,6 +257,9 @@ func (d *diffCmd) runHelm3() error {`
`257`	`257`	`return errors.Wrap(err, "unable to build kubernetes objects from new release manifest")`
`258`	`258`	`}`
`259`	`259`	`releaseManifest, installManifest, err = genManifest(original, target)`
	`260`	`+ if err != nil {`
	`261`	`+ return errors.Wrap(err, "unable to generate manifests")`
	`262`	`+ }`
`260`	`263`	`}`
`261`	`264`
`262`	`265`	`currentSpecs := make(map[string]*manifest.MappingResult)`