Skip to content

Commit 99e1351

Browse files
jonasrutishausermumoshu
authored andcommitted
fix issues in --reset-values and --reuse-values on helm v3 (#160)
Correction of #159
1 parent 8c96244 commit 99e1351

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

cmd/helm3.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ func (d *diffCmd) template() ([]byte, error) {
6565
// Helm automatically enable --reuse-values when there's no --set, --set-string, --set-values, --set-file present.
6666
// Let's simulate that in helm-diff.
6767
// See https://medium.com/@kcatstack/understand-helm-upgrade-flags-reset-values-reuse-values-6e58ac8f127e
68-
shouldDefaultReusingValues := len(d.values) > 0 && len(d.stringValues) > 0 && len(d.valueFiles) > 0 && len(d.fileValues) > 0
68+
shouldDefaultReusingValues := len(d.values) == 0 && len(d.stringValues) == 0 && len(d.valueFiles) == 0 && len(d.fileValues) == 0
6969
if (d.reuseValues || shouldDefaultReusingValues) && !d.resetValues {
7070
tmpfile, err := ioutil.TempFile("", "existing-values")
7171
if err != nil {

0 commit comments

Comments
 (0)