Skip to content

Commit 9ec583c

Browse files
authored
Fix for Install-Binary script (#307)
* fixed install-binary.sh script + linting of some go code. * correct HELM_HOME
1 parent 494eef0 commit 9ec583c

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

install-binary.sh

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,15 @@ PROJECT_NAME="helm-diff"
66
PROJECT_GH="databus23/$PROJECT_NAME"
77
export GREP_COLOR="never"
88

9+
[ -z "$HELM_BIN" ] && HELM_BIN=$(which helm)
910
HELM_MAJOR_VERSION=$("${HELM_BIN}" version --client --short | awk -F '.' '{print $1}')
1011

11-
: ${HELM_PLUGIN_DIR:="$("${HELM_BIN}" home --debug=false)/plugins/helm-diff"}
12+
HELM_HOME=$("${HELM_BIN}" home --debug=false)
13+
[ -z "$HELM_HOME" ] && HELM_HOME=$(helm env | grep 'HELM_DATA_HOME' | cut -d '=' -f2 | tr -d '"')
14+
15+
mkdir -p "$HELM_HOME"
16+
17+
: ${HELM_PLUGIN_DIR:="$HELM_HOME/plugins/helm-diff"}
1218

1319
# Convert the HELM_PLUGIN_DIR to unix if cygpath is
1420
# available. This is the case when using MSYS2 or Cygwin
@@ -100,7 +106,7 @@ downloadFile() {
100106
installFile() {
101107
HELM_TMP="/tmp/$PROJECT_NAME"
102108
mkdir -p "$HELM_TMP"
103-
tar xf "$PLUGIN_TMP_FILE" -C "$HELM_TMP"
109+
tar xvzf "$PLUGIN_TMP_FILE" -C "$HELM_TMP"
104110
HELM_TMP_BIN="$HELM_TMP/diff/bin/diff"
105111
echo "Preparing to install into ${HELM_PLUGIN_DIR}"
106112
mkdir -p "$HELM_PLUGIN_DIR/bin"

0 commit comments

Comments
 (0)