Skip to content

Commit 9429caa

Browse files
authored
Remove obsolete 'conn' and 'cursor' params from metastore methods (#1623)
1 parent c6ec31f commit 9429caa

File tree

7 files changed

+99
-205
lines changed

7 files changed

+99
-205
lines changed

src/datachain/catalog/catalog.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1004,11 +1004,9 @@ def update_dataset_version_with_warehouse_info(
10041004

10051005
self.metastore.update_dataset_version(dataset, version, **values)
10061006

1007-
def update_dataset(
1008-
self, dataset: DatasetRecord, conn=None, **kwargs
1009-
) -> DatasetRecord:
1007+
def update_dataset(self, dataset: DatasetRecord, **kwargs) -> DatasetRecord:
10101008
"""Updates dataset fields."""
1011-
dataset_updated = self.metastore.update_dataset(dataset, conn=conn, **kwargs)
1009+
dataset_updated = self.metastore.update_dataset(dataset, **kwargs)
10121010
self.warehouse.rename_dataset_tables(dataset, dataset_updated)
10131011
return dataset_updated
10141012

src/datachain/data_storage/db_engine.py

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -79,12 +79,7 @@ def compile_to_args(
7979
return result.string, params
8080

8181
@abstractmethod
82-
def execute(
83-
self,
84-
query,
85-
cursor: Any | None = None,
86-
conn: Any | None = None,
87-
) -> Iterator[tuple[Any, ...]]: ...
82+
def execute(self, query) -> Iterator[tuple[Any, ...]]: ...
8883

8984
def get_table(self, name: str) -> "Table":
9085
"""Get a table by name, raising TableMissingError if not found."""
@@ -100,9 +95,7 @@ def get_table(self, name: str) -> "Table":
10095
return table
10196

10297
@abstractmethod
103-
def executemany(
104-
self, query, params, cursor: Any | None = None
105-
) -> Iterator[tuple[Any, ...]]: ...
98+
def executemany(self, query, params) -> None: ...
10699

107100
@abstractmethod
108101
def execute_str(self, sql: str, parameters=None) -> Iterator[tuple[Any, ...]]: ...

0 commit comments

Comments
 (0)