Improve pre-merge tests and code formatting (#212)

- Add `set -e` to the test script. This fixes an issue where PR checks
have been passing even when tests fail because the test script overall
exits with code 0.
- Add test script modes for env setup, lint fix, and running all tests.
Before, "Python test" mode also set up the environment and ran
formatting tests.
- Add isort alongside yapf. This follows precedent in the website repo.
- Add datacommons_client dir to the paths checked by yapf (and isort).
- Rename run_tests to run_test for consistency with other repos.

Author: hqpho

cloudbuild.yaml

@@ -4,4 +4,4 @@ steps:
     entrypoint: /bin/sh
     args:
       - -c
-      - "./run_tests.sh -p"
+      - "./run_test.sh -s -a"

datacommons/__init__.py

@@ -12,6 +12,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+# isort: skip_file
+
 ################################## IMPORTANT #################################
 # All user-facing functions in this package must be symlinked to the         #
 # datacommons_pandas pkg. This is so that users do not need to import both   #
@@ -30,4 +32,4 @@
 from datacommons.stat_vars import get_stat_value, get_stat_series, get_stat_all
 
 from datacommons.key import set_api_key
-from datacommons.node import properties, property_values, triples
+from datacommons.node import properties, property_values, triples

datacommons/examples/stat_vars.py

@@ -17,9 +17,10 @@
 from __future__ import division
 from __future__ import print_function
 
-import datacommons as dc
 import pprint
 
+import datacommons as dc
+
 
 def main():
   param_sets = [

datacommons/requests.py

@@ -14,9 +14,10 @@
 """ Send http requests to Data Commons REST API endpoints.
 """
 
-import requests
 from typing import Dict
 
+import requests
+
 import datacommons.key as key
 
 # REST API endpoint root

datacommons/setup.py

@@ -13,6 +13,7 @@
 # limitations under the License.
 """Build and distribute the datacommons package to PyPI."""
 import os
+
 from setuptools import setup
 
 dir_path = os.path.dirname(os.path.realpath(__file__))

datacommons/stat_vars.py

@@ -21,6 +21,7 @@
 from __future__ import print_function
 
 import collections
+
 import six
 
 import datacommons.utils as utils

datacommons/test/core_test.py

@@ -25,12 +25,13 @@
 except ImportError:
   from mock import patch
 
+import json
+import unittest
+
 import six.moves.urllib as urllib
 
 import datacommons as dc
 import datacommons.utils as utils
-import json
-import unittest
 
 
 def request_mock(*args, **kwargs):

datacommons/test/places_test.py

@@ -25,12 +25,14 @@
 except ImportError:
   from mock import patch
 
-import datacommons as dc
-import datacommons.utils as utils
 import json
 import unittest
+
 import six.moves.urllib as urllib
 
+import datacommons as dc
+import datacommons.utils as utils
+
 
 def request_mock(*args, **kwargs):
   """ A mock urlopen requests sent in the requests package. """

datacommons/test/stat_vars_test.py

@@ -25,13 +25,15 @@
 except ImportError:
   from mock import patch
 
-import datacommons as dc
-import datacommons.utils as utils
-import math
 import json
+import math
 import unittest
+
 import six.moves.urllib as urllib
 
+import datacommons as dc
+import datacommons.utils as utils
+
 # Reusable parts of REST API /stat/all response.
 CA_COUNT_PERSON = {
     "isDcAggregate":

datacommons/utils.py

@@ -20,14 +20,14 @@
 from __future__ import division
 from __future__ import print_function
 
-from collections import defaultdict
-
 import base64
+from collections import defaultdict
 import json
 import os
+import zlib
+
 import six.moves.urllib.error
 import six.moves.urllib.request
-import zlib
 
 # --------------------------------- CONSTANTS ---------------------------------