Merge pull request #498 from datafruits/default-avatars

set default user avatars

Author: mcfiredrill

app/models/user.rb

@@ -75,6 +75,8 @@ class User < ActiveRecord::Base
 
   after_update :maybe_send_update_notification
 
+  before_save :set_default_avatar, unless: -> { ::Rails.env.test? }
+
   def login=(login)
     @login = login
   end
@@ -144,4 +146,17 @@ def maybe_send_update_notification
       Notification.create! notification_type: "avatar_update", source: self, send_to_chat: true, send_to_user: false, user: self, url: url
     end
   end
+
+  def set_default_avatar
+    unless self.image.present?
+      # TODO use in test when we switch to active storage
+      if ::Rails.env === "test"
+        random_avatar = File.new ::Rails.root.join("config/default_avatars/default_avatar_1.png")
+        self.image = random_avatar
+      else
+        random_avatar = File.new ::Rails.root.join("config/default_avatars/default_avatar_#{rand(1..5)}.png")
+        self.image = random_avatar
+      end
+    end
+  end
 end

config/default_avatars/default_avatar_1.png

@@ -43,4 +43,11 @@
       expect(user.deleted_at).to_not eq nil
     end
   end
+
+  describe "default avatar" do
+    xit "sets a random default avatar if none is set" do
+      user = User.create! email: "[email protected]", time_zone: "Tokyo", role: "admin", password: "testtest"
+      expect(user.image.path).to include("default_avatar")
+    end
+  end
 end