Skip to content

Commit 13c08c9

Browse files
committed
Remove unused shuffle-task-batch-size
1 parent fed143e commit 13c08c9

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

benchmarks/cdk/bin/datafusion-bench.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ async function main() {
1414
.option('-i, --iterations <number>', 'Number of iterations', '3')
1515
.option('--files-per-task <number>', 'Files per task', '4')
1616
.option('--cardinality-task-sf <number>', 'Cardinality task scale factor', '2')
17-
.option('--shuffle-batch-size <number>', 'Shuffle batch coalescing size (number of rows)', '8192')
1817
.option('--query <number>', 'A specific query to run', undefined)
1918
.parse(process.argv);
2019

@@ -24,13 +23,11 @@ async function main() {
2423
const iterations = parseInt(options.iterations);
2524
const filesPerTask = parseInt(options.filesPerTask);
2625
const cardinalityTaskSf = parseInt(options.cardinalityTaskSf);
27-
const shuffleBatchSize = parseInt(options.shuffleBatchSize);
2826
const specificQuery = options.query ? parseInt(options.query) : undefined;
2927

3028
const runner = new DataFusionRunner({
3129
filesPerTask,
3230
cardinalityTaskSf,
33-
shuffleBatchSize,
3431
});
3532

3633
const outputPath = path.join(ROOT, "benchmarks", "data", `tpch_sf${sf}`, "remote-results.json");
@@ -55,7 +52,6 @@ class DataFusionRunner implements BenchmarkRunner {
5552
constructor(private readonly options: {
5653
filesPerTask: number;
5754
cardinalityTaskSf: number;
58-
shuffleBatchSize: number;
5955
}) {
6056
}
6157

@@ -100,8 +96,7 @@ class DataFusionRunner implements BenchmarkRunner {
10096
await this.query(stmt);
10197
await this.query(`
10298
SET distributed.files_per_task=${this.options.filesPerTask};
103-
SET distributed.cardinality_task_count_factor=${this.options.cardinalityTaskSf};
104-
SET distributed.shuffle_batch_size=${this.options.shuffleBatchSize}
99+
SET distributed.cardinality_task_count_factor=${this.options.cardinalityTaskSf}
105100
`);
106101
}
107102

0 commit comments

Comments
 (0)