incorporate feedback

Author: adriangb

src/protobuf/distributed_codec.rs

@@ -46,6 +46,9 @@ impl PhysicalExtensionCodec for DistributedCodec {
             ));
         };
 
+        // TODO: The PhysicalExtensionCodec trait doesn't provide access to session state,
+        // so we create a new SessionContext which loses any custom UDFs, UDAFs, and other
+        // user configurations. This is a limitation of the current trait design.
         let ctx = SessionContext::new();
 
         match distributed_exec_node {

src/protobuf/errors/arrow_error.rs

@@ -8,7 +8,7 @@ pub struct ArrowErrorProto {
     pub ctx: Option<String>,
     #[prost(
         oneof = "ArrowErrorInnerProto",
-        tags = "2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19"
+        tags = "2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20"
     )]
     pub inner: Option<ArrowErrorInnerProto>,
 }
@@ -51,6 +51,8 @@ pub enum ArrowErrorInnerProto {
     DictionaryKeyOverflowError(bool),
     #[prost(bool, tag = "19")]
     RunEndIndexOverflowError(bool),
+    #[prost(uint64, tag = "20")]
+    OffsetOverflowError(u64),
 }
 
 impl ArrowErrorProto {
@@ -131,9 +133,7 @@ impl ArrowErrorProto {
                 ctx: ctx.cloned(),
             },
             ArrowError::OffsetOverflowError(offset) => ArrowErrorProto {
-                inner: Some(ArrowErrorInnerProto::ParseError(format!(
-                    "Offset overflow error: {offset}"
-                ))),
+                inner: Some(ArrowErrorInnerProto::OffsetOverflowError(*offset as u64)),
                 ctx: ctx.cloned(),
             },
         }
@@ -182,6 +182,9 @@ impl ArrowErrorProto {
             ArrowErrorInnerProto::RunEndIndexOverflowError(_) => {
                 ArrowError::RunEndIndexOverflowError
             }
+            ArrowErrorInnerProto::OffsetOverflowError(offset) => {
+                ArrowError::OffsetOverflowError(*offset as usize)
+            }
         };
         (err, self.ctx.clone())
     }
@@ -220,6 +223,7 @@ mod tests {
             ArrowError::CDataInterface("cdata error".to_string()),
             ArrowError::DictionaryKeyOverflowError,
             ArrowError::RunEndIndexOverflowError,
+            ArrowError::OffsetOverflowError(12345),
         ];
 
         for original_error in test_cases {