Skip to content

Commit ae86178

Browse files
committed
Some cleanup
1 parent 1209188 commit ae86178

File tree

2 files changed

+6
-20
lines changed

2 files changed

+6
-20
lines changed

tests/common/mod.rs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,3 @@
1-
//! Utility functions and structures for TPC-H validation tests
2-
//!
3-
//! This module contains reusable components for testing distributed DataFusion
4-
//! against standard DataFusion using TPC-H queries.
5-
61
use std::fs;
72
use std::io::Read;
83
use std::path::Path;

tests/tpch_validation.rs

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,20 @@
44
//! between regular DataFusion and distributed DataFusion systems.
55
//!
66
//! ## Features
7-
//! - Automatic cluster setup and teardown
8-
//! - Automatic TPC-H data generation
9-
//! - Automatic dependency installation
7+
//! - Automatic cluster setup and teardown on test ports 40400, 40401, ...
8+
//! - Automatic installation of tpchgen-cli if needed to generate TPC-H scale factor 1 data at /tmp/tpch_s1 if not present
9+
//! - Automatic installation of Python Flight SQL packages if needed
10+
//! - Automatic generation of a reusable Python script to execute queries on the cluster
1011
//! - Complete result comparison with tolerance
1112
//! - CI-ready with detailed reporting
12-
//! - Fast execution with minimal output (only top 2 rows for large results)
13+
//! - Fast execution with minimal output (only top 2 rows for large results) and verbose output for debugging specific queries
1314
//! - Configurable verbosity for debugging specific queries
1415
//! - Configurable timing parameters for cluster startup and polling
1516
//! - Modular design with reusable helper functions
1617
//! - Safe concurrent execution (only affects designated test ports)
1718
//!
1819
//! ## Usage
1920
//!
20-
//! Just run the tests - everything is automated:
2121
//! ```bash
2222
//! # Run all TPC-H validation tests
2323
//! cargo test --test tpch_validation test_tpch_validation_all_queries -- --ignored --nocapture
@@ -28,15 +28,6 @@
2828
//! # Enable verbose output for debugging specific queries
2929
//! # Modify the should_be_verbose() function in utils.rs to return true for specific queries
3030
//! ```
31-
//!
32-
//! ## What the tests do automatically:
33-
//! 1. Clean up any existing processes on test ports 40400-40402 only
34-
//! 2. Install tpchgen-cli if not available
35-
//! 3. Generate TPC-H scale factor 1 data at /tmp/tpch_s1 if not present
36-
//! 4. Start distributed cluster (1 proxy + 2 workers)
37-
//! 5. Run validation tests comparing DataFusion vs Distributed for all 22 TPC-H queries in ./tpch/queries/
38-
//! 6. Clean up test cluster processes (without affecting other instances)
39-
//!
4031
use std::time::Instant;
4132

4233
mod common;
@@ -132,7 +123,7 @@ async fn test_tpch_validation_all_queries() {
132123
/// This test is marked with #[ignore] - use `cargo test --ignored` to run it.
133124
/// Modify the query_name to test different queries.
134125
///
135-
/// To enable verbose output for debugging, modify the `should_be_verbose` function in utils.rs.
126+
/// To enable verbose output for debugging, modify the `should_be_verbose` function in common/mod.rs.
136127
#[tokio::test]
137128
#[ignore]
138129
async fn test_tpch_validation_single_query() {

0 commit comments

Comments
 (0)