Skip to content

Do not require default datafusion features #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2025
Merged

Do not require default datafusion features #154

merged 1 commit into from
Sep 24, 2025

Conversation

@gabotechs
Copy link
Collaborator

@gabotechs gabotechs commented Sep 24, 2025

We do not use any of the default datafusion features, so do not require them. This has two benefits:

  • faster compile times, as we are compiling less things
  • we do not force consumers of this library to bring in all default datafusion features, as they might not want to

NGA-TRAN
NGA-TRAN approved these changes Sep 24, 2025
View reviewed changes
Copy link
Collaborator

@NGA-TRAN NGA-TRAN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@gabotechs gabotechs merged commit a8597a0 into main Sep 24, 2025
4 checks passed
@gabotechs gabotechs deleted the gabrielmusat/do-not-require-default-datafusion-features branch September 24, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NGA-TRAN NGA-TRAN NGA-TRAN approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gabotechs @NGA-TRAN