-
Notifications
You must be signed in to change notification settings - Fork 14
Add dynamic task config based on DataFusion extension options #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1f3b632 to
e2fee7f
Compare
e2fee7f to
c5698c2
Compare
NGA-TRAN
approved these changes
Oct 20, 2025
Collaborator
NGA-TRAN
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
I only have minor questions to remind myself
jayshrivastava
approved these changes
Oct 22, 2025
Base automatically changed from
gabrielmusat/refactor-distributed-planner
to
main
October 22, 2025 14:50
# Conflicts: # src/distributed_planner/distributed_physical_optimizer_rule.rs # src/distributed_planner/mod.rs # src/lib.rs
Collaborator
Author
|
I'm finding this API a bit annoying to work with in the end... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhances the way we configure the
network_coalesce_tasksandnetwork_shuffle_tasksparameters. Rather than having these parameters as part of theDistributedPhysicalOptimizerRule, they are now it's own structure that implementsConfigExtension, the standard DataFusion way of passing configuration.This allows us to ship two main enhancements: