Fix user provided UDFs encoding #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabotechs
commented
Oct 22, 2025
Collaborator
Author
There was a problem hiding this comment.
This test replicates the issue and ensures it never happens again.
gabotechs
force-pushed
the
fix-udfs-encoding
branch
from
50131c8 to
c5d6114
Compare
NGA-TRAN
approved these changes
Oct 22, 2025
Collaborator
NGA-TRAN
left a comment
NGA-TRAN
left a comment
There was a problem hiding this comment.
LGTM, assuming the UDF is consistently registered using with_scalar_functions.
| let state = SessionStateBuilder::new() | ||
| .with_scalar_functions( | ||
| registry | ||
| .udfs() |
Collaborator
There was a problem hiding this comment.
Question: is UDF always registered with with_scalar_functions?
Collaborator
Author
There was a problem hiding this comment.
I think there's other ways of registering them, but they are pretty much aliases to this one, all will result in the same: a SessionContext with some UDFs in it.
jayshrivastava
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a UDF was inside a
Partitioningfield, we were failing to deserialize it as there we have a recently builtSessionContextwith no notion of UDFs.This is a limitation of DF APIs that will be addressed in future releases, but for now, this fix should be enough.