remove schema adapter #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabotechs
reviewed
Oct 27, 2025
Collaborator
gabotechs
left a comment
gabotechs
left a comment
There was a problem hiding this comment.
Nice! I imagine this could potentially allows to save on bandwidth for when dictionary encoded values are in the schema.
|
|
||
| let stream = FlightDataEncoderBuilder::new() | ||
| .with_schema(stream.schema().clone()) | ||
| .with_dictionary_handling(DictionaryHandling::Resend) |
Collaborator
There was a problem hiding this comment.
So, with this line, we are telling the flight data encoder to just send the dictionaries over the wire instead of hydrating them and re-encoding them. Is that right?
If you could include a very brief comment above this line that would be awesome 🙏
Collaborator
There was a problem hiding this comment.
This is a great optimization. Thanks @adriangb
adriangb
commented
Oct 27, 2025
gabotechs
approved these changes
Oct 27, 2025
Co-authored-by: Gabriel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added in #174 but I think a better fix is to just configure the IPC encoder to send dictionaries across the wire.