Skip to content

fix(datafusion-distributed): relax ttl map timing constraints #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2025
Merged

fix(datafusion-distributed): relax ttl map timing constraints #218

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ccaebb
Relax timing constraints.
JSOD11 Nov 11, 2025
af16581
Remove unnecessary changes. Add minor fixes.
JSOD11 Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/common/ttl_map.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
//! How the Time Wheel Works
//!
//! Time Buckets: [0] [1] [2] [3] [4] [5] [6] [7] ...
//! Current Time: ^
//! |
//! time % buckets.len()
//! Current Time: ^
//! |
//! (time-1) % buckets.len()
//!
//! When inserting key "A" at time=2:
//! - Key "A" goes into bucket[(2-1) % 8] = bucket[1]
Expand Down Expand Up @@ -205,7 +205,7 @@ where
self.gc_scheduler_task = Some(vec![gc_task]);
}

/// get_or_default executes the provided closure with a reference to the map entry for the given key.
/// get_or_init executes the provided closure with a reference to the map entry for the given key.
/// If the key does not exist, it inserts a new entry with the default value.
pub fn get_or_init<F>(&self, key: K, init: F) -> V
where
Expand Down Expand Up @@ -374,7 +374,7 @@ mod tests {
F: Fn() -> bool,
{
let start = std::time::Instant::now();
while start.elapsed() < timeout {
while start.elapsed() <= timeout {
if assertion() {
return;
}
Expand All @@ -384,7 +384,6 @@ mod tests {
}

#[tokio::test(flavor = "multi_thread", worker_threads = 8)]
#[ignore] // the test is flaky, uncomment once flakyness is solved
async fn test_concurrent_gc_and_access() {
let ttl_map = TTLMap::<String, i32>::try_new(TTLMapConfig {
ttl: Duration::from_millis(10),
Expand Down Expand Up @@ -421,7 +420,7 @@ mod tests {
handle.await.unwrap();
}

assert_eventually(|| ttl_map.data.is_empty(), Duration::from_millis(20)).await;
assert_eventually(|| ttl_map.data.is_empty(), Duration::from_millis(100)).await;
}

#[tokio::test]
Expand Down