Merge pull request #13 from dariocurr/update-deps

bump datafusion from 43 to 49

Author: dariocurr

.github/dependabot.yml

@@ -0,0 +1,14 @@
+version: 2
+
+updates:
+  - package-ecosystem: github-actions
+    directory: /
+    schedule:
+      interval: daily
+    target-branch: develop
+
+  - package-ecosystem: cargo
+    directory: /
+    schedule:
+      interval: daily
+    target-branch: develop

.pre-commit-config.yaml

@@ -19,7 +19,7 @@ fail_fast: true
 
 repos:
 - repo: https://github.com/pre-commit/pre-commit-hooks
-  rev: v4.0.1
+  rev: v6.0.0
   hooks:
   - id: check-yaml
   - id: check-toml

.rustfmt.toml

@@ -18,34 +18,47 @@
 [package]
 name = "datafusion-functions-extra"
 version = "0.2.0"
-edition = "2021"
+edition = "2024"
 description = "Extra Functions for DataFusion"
 readme = "README.md"
 license = "Apache-2.0"
-keywords = ["datafusion", "functions-extra", "aggregations"]
+keywords = [
+    "aggregations",
+    "datafusion",
+    "functions-extra",
+]
 repository = "https://github.com/datafusion-contrib/datafusion-functions-extra/"
-rust-version = "1.76"
-
-[lib]
-name = "datafusion_functions_extra"
-path = "src/lib.rs"
 
 [dependencies]
-arrow = { version = "53.0.0", features = ["test_utils"] }
-datafusion = "42"
-log = "^0.4"
-paste = "1"
+log = "0.4"
+paste = "1.0"
+
+[dependencies.datafusion]
+default-features = false
+version = "49.0"
 
 [dev-dependencies]
-arrow = { version = "53.0.0", features = ["test_utils"] }
-criterion = { version = "0.5", features = ["async_tokio"] }
-insta = { version = "1.40.0", features = ["yaml"] }
-tokio = { version = "1.36", features = ["full"] }
+criterion = "0.7"
+rand = "0.9"
+tokio = "1.47"
 
-[lints.clippy]
-dbg_macro = "deny"
-print_stdout = "deny"
+[dev-dependencies.arrow]
+default-features = false
+features = [
+    "test_utils",
+]
+version = "55.0"
+
+[dev-dependencies.insta]
+features = [
+    "yaml",
+]
+version = "1.43"
 
 [[bench]]
 name = "mode"
 harness = false
+
+[lints.clippy]
+dbg_macro = "deny"
+print_stdout = "deny"

Cargo.toml

@@ -15,44 +15,40 @@
 // specific language governing permissions and limitations
 // under the License.
 
-use std::sync::Arc;
-
 use arrow::util::bench_util::{create_primitive_array, create_string_array};
-use criterion::{black_box, criterion_group, criterion_main, Criterion};
-use datafusion::{
-    arrow::{
-        self,
-        array::ArrayRef,
-        datatypes::{DataType, Int32Type},
-    },
-    logical_expr::Accumulator,
-};
+use criterion::{Criterion, criterion_group, criterion_main};
+use datafusion::{arrow, logical_expr::Accumulator};
 use datafusion_functions_extra::common::mode::{BytesModeAccumulator, PrimitiveModeAccumulator};
+use std::{hint, slice, sync};
 
 fn prepare_primitive_mode_accumulator() -> Box<dyn Accumulator> {
-    Box::new(PrimitiveModeAccumulator::<Int32Type>::new(&DataType::Int32))
+    Box::new(
+        PrimitiveModeAccumulator::<arrow::datatypes::Int32Type>::new(
+            &arrow::datatypes::DataType::Int32,
+        ),
+    )
 }
 
 fn prepare_bytes_mode_accumulator() -> Box<dyn Accumulator> {
-    Box::new(BytesModeAccumulator::new(&DataType::Utf8))
+    Box::new(BytesModeAccumulator::new(&arrow::datatypes::DataType::Utf8))
 }
 
-fn mode_bench_primitive(c: &mut Criterion, name: &str, values: ArrayRef) {
+fn mode_bench_primitive(c: &mut Criterion, name: &str, values: arrow::array::ArrayRef) {
     let mut accumulator = prepare_primitive_mode_accumulator();
     c.bench_function(name, |b| {
         b.iter(|| {
-            accumulator.update_batch(&[values.clone()]).unwrap();
-            black_box(accumulator.evaluate().unwrap());
+            accumulator.update_batch(slice::from_ref(&values)).unwrap();
+            hint::black_box(accumulator.evaluate().unwrap());
         });
     });
 }
 
-fn mode_bench_bytes(c: &mut Criterion, name: &str, values: ArrayRef) {
+fn mode_bench_bytes(c: &mut Criterion, name: &str, values: arrow::array::ArrayRef) {
     let mut accumulator = prepare_bytes_mode_accumulator();
     c.bench_function(name, |b| {
         b.iter(|| {
-            accumulator.update_batch(&[values.clone()]).unwrap();
-            black_box(accumulator.evaluate().unwrap());
+            accumulator.update_batch(slice::from_ref(&values)).unwrap();
+            hint::black_box(accumulator.evaluate().unwrap());
         });
     });
 }
@@ -63,7 +59,10 @@ fn mode_benchmark(c: &mut Criterion) {
 
     for &size in &sizes {
         for &null_percentage in &null_percentages {
-            let values = Arc::new(create_primitive_array::<Int32Type>(size, null_percentage)) as ArrayRef;
+            let values = sync::Arc::new(create_primitive_array::<arrow::datatypes::Int32Type>(
+                size,
+                null_percentage,
+            )) as arrow::array::ArrayRef;
             let name = format!(
                 "PrimitiveModeAccumulator: {} elements, {}% nulls",
                 size,
@@ -75,7 +74,8 @@ fn mode_benchmark(c: &mut Criterion) {
 
     for &size in &sizes {
         for &null_percentage in &null_percentages {
-            let values = Arc::new(create_string_array::<i32>(size, null_percentage)) as ArrayRef;
+            let values = sync::Arc::new(create_string_array::<i32>(size, null_percentage))
+                as arrow::array::ArrayRef;
             let name = format!(
                 "BytesModeAccumulator: {} elements, {}% nulls",
                 size,