Skip to content

Commit 768b109

Browse files
committed
Address code review feedback and enhance PostgreSQL compatibility
Major improvements: - Make query timeout configurable via ServerOptions (default 300s) - Fix error handling to use proper type checking instead of string matching - Add comprehensive unit tests for enhance_query_with_type_casting function - Remove connection timeout that limited max connection lifetime - Add support for PostgreSQL oid, regtype, regclass, regproc type translation - Register pg_catalog tables in public schema for asyncpg compatibility - Add set_config() function for PostgreSQL client compatibility - Add maintenance command support (UNLISTEN, RESET, DISCARD, DEALLOCATE) - Fix schema resolution issues for unqualified table access - Add .DS_Store to .gitignore for macOS compatibility Code quality improvements: - Fix clippy warnings (useless format, redundant closures) - Add comprehensive test coverage - Improve error handling patterns - Make CLI async-compatible These changes significantly improve PostgreSQL protocol compatibility and address connection stability issues under load.
1 parent c7a9a2e commit 768b109

File tree

5 files changed

+298
-82
lines changed

5 files changed

+298
-82
lines changed

.gitignore

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,8 @@
33
.envrc
44
.vscode
55
.aider*
6-
/test_env
6+
/test_env
7+
8+
# OS
9+
.DS_Store
10+
Thumbs.db

datafusion-postgres-cli/src/main.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ async fn setup_session_context(
179179
}
180180

181181
// Register pg_catalog
182-
setup_pg_catalog(session_context, "datafusion")?;
182+
setup_pg_catalog(session_context, "datafusion").await?;
183183

184184
Ok(())
185185
}

0 commit comments

Comments
 (0)