fix: Complete format string modernization for clippy

- Fix all remaining clippy::uninlined_format_args warnings
- Update format strings in handlers.rs, auth.rs, and lib.rs
- Modernize 13 format! macros to use inline variable syntax
- Ensures full compliance with clippy --all-features -- -D warnings

Author: iPeluwa

datafusion-postgres/src/auth.rs

@@ -182,7 +182,7 @@ impl AuthManager {
 
                 // Create predefined roles
                 if let Err(e) = auth_manager_spawn.create_predefined_roles().await {
-                    eprintln!("Failed to create predefined roles: {:?}", e);
+                    eprintln!("Failed to create predefined roles: {e:?}");
                 }
             }
         });
@@ -282,7 +282,7 @@ impl AuthManager {
                 pgwire::error::ErrorInfo::new(
                     "ERROR".to_string(),
                     "42704".to_string(), // undefined_object
-                    format!("role \"{}\" does not exist", role_name),
+                    format!("role \"{role_name}\" does not exist"),
                 ),
             )))
         }
@@ -306,7 +306,7 @@ impl AuthManager {
                 pgwire::error::ErrorInfo::new(
                     "ERROR".to_string(),
                     "42704".to_string(), // undefined_object
-                    format!("role \"{}\" does not exist", role_name),
+                    format!("role \"{role_name}\" does not exist"),
                 ),
             )))
         }
@@ -410,7 +410,7 @@ impl AuthManager {
             // Schema grants access to all tables in that schema
             (ResourceType::Schema(schema), ResourceType::Table(table)) => {
                 // For simplicity, assume table names are schema.table format
-                table.starts_with(&format!("{}.", schema))
+                table.starts_with(&format!("{schema}."))
             }
             _ => false,
         }
@@ -434,7 +434,7 @@ impl AuthManager {
                 pgwire::error::ErrorInfo::new(
                     "ERROR".to_string(),
                     "42704".to_string(), // undefined_object
-                    format!("role \"{}\" does not exist", child_role),
+                    format!("role \"{child_role}\" does not exist"),
                 ),
             )))
         }
@@ -456,7 +456,7 @@ impl AuthManager {
                 pgwire::error::ErrorInfo::new(
                     "ERROR".to_string(),
                     "42704".to_string(), // undefined_object
-                    format!("role \"{}\" does not exist", child_role),
+                    format!("role \"{child_role}\" does not exist"),
                 ),
             )))
         }
@@ -623,7 +623,7 @@ impl StartupHandler for AuthStartupHandler {
                     pgwire::error::ErrorInfo::new(
                         "FATAL".to_string(),
                         "28P01".to_string(), // invalid_password
-                        format!("password authentication failed for user \"{}\"", username),
+                        format!("password authentication failed for user \"{username}\""),
                     ),
                 )));
             }
@@ -670,7 +670,7 @@ impl AuthSource for SimpleAuthSource {
             pgwire::error::ErrorInfo::new(
                 "FATAL".to_string(),
                 "28P01".to_string(), // invalid_password
-                format!("password authentication failed for user \"{}\"", username),
+                format!("password authentication failed for user \"{username}\""),
             ),
         )))
     }

datafusion-postgres/src/handlers.rs

@@ -146,7 +146,7 @@ impl DfSessionService {
                 pgwire::error::ErrorInfo::new(
                     "ERROR".to_string(),
                     "42501".to_string(), // insufficient_privilege
-                    format!("permission denied for user \"{}\"", username),
+                    format!("permission denied for user \"{username}\""),
                 ),
             )));
         }

datafusion-postgres/src/lib.rs

@@ -85,14 +85,11 @@ pub async fn serve(
         if let (Some(cert_path), Some(key_path)) = (&opts.tls_cert_path, &opts.tls_key_path) {
             match setup_tls(cert_path, key_path) {
                 Ok(acceptor) => {
-                    println!(
-                        "TLS enabled using cert: {} and key: {}",
-                        cert_path, key_path
-                    );
+                    println!("TLS enabled using cert: {cert_path} and key: {key_path}");
                     Some(acceptor)
                 }
                 Err(e) => {
-                    eprintln!("Failed to setup TLS: {}. Running without encryption.", e);
+                    eprintln!("Failed to setup TLS: {e}. Running without encryption.");
                     None
                 }
             }
@@ -106,9 +103,9 @@ pub async fn serve(
     let listener = TcpListener::bind(&server_addr).await?;
 
     if tls_acceptor.is_some() {
-        println!("Listening on {} with TLS encryption", server_addr);
+        println!("Listening on {server_addr} with TLS encryption");
     } else {
-        println!("Listening on {} (unencrypted)", server_addr);
+        println!("Listening on {server_addr} (unencrypted)");
     }
 
     // Accept incoming connections