Upgrade Rust toolchain from 1.86 to 1.89 (#456)

* Upgrade Rust toolchain from 1.86 to 1.89

* Fix Clippy issues

Author: lukekim

README.md

@@ -178,6 +178,7 @@ cargo run -p datafusion-table-providers --example flight-sql --features flight
 ```
 
 ### ODBC
+
 ```bash
 apt-get install unixodbc-dev libsqliteodbc
 # or
@@ -191,18 +192,22 @@ cargo run --example odbc_sqlite --features odbc
 Please see https://github.com/pacman82/odbc-api#os-x-arm--mac-m1 for reference.
 
 Steps:
+
 1. Install unixodbc and sqliteodbc by `brew install unixodbc sqliteodbc`.
 2. Find local sqliteodbc driver path by running `brew info sqliteodbc`. The path might look like `/opt/homebrew/Cellar/sqliteodbc/0.99991`.
 3. Set up odbc config file at `~/.odbcinst.ini` with your local sqliteodbc path.
-Example config file:
+   Example config file:
+
 ```
 [SQLite3]
 Description = SQLite3 ODBC Driver
 Driver      = /opt/homebrew/Cellar/sqliteodbc/0.99991/lib/libsqlite3odbc.dylib
 ```
+
 4. Test configuration by running `odbcinst -q -d -n SQLite3`. If the path is printed out correctly, then you are all set.
 
 ## Examples (in Python)
+
 1. Start a Python venv
 2. Enter into venv
 3. Inside python/ folder, run `maturin develop`.

core/src/duckdb/write.rs

@@ -254,10 +254,13 @@ impl DataSink for DuckDBDataSink {
             let batch = batch.map_err(check_and_mark_retriable_error)?;
 
             if let Some(constraints) = self.table_definition.constraints() {
-                constraints::validate_batch_with_constraints(&[batch.clone()], constraints)
-                    .await
-                    .context(super::ConstraintViolationSnafu)
-                    .map_err(to_datafusion_error)?;
+                constraints::validate_batch_with_constraints(
+                    std::slice::from_ref(&batch),
+                    constraints,
+                )
+                .await
+                .context(super::ConstraintViolationSnafu)
+                .map_err(to_datafusion_error)?;
             }
 
             if let Err(send_error) = batch_tx.send(batch).await {

core/src/mysql/federation.rs

@@ -54,7 +54,7 @@ fn mysql_ast_analyzer(ast: ast::Statement) -> Result<ast::Statement, DataFusionE
             let mut new_query = query.clone();
 
             let mut window_visitor = MySQLWindowVisitor::default();
-            new_query.visit(&mut window_visitor);
+            let _ = new_query.visit(&mut window_visitor);
 
             Ok(ast::Statement::Query(new_query))
         }

core/src/mysql/write.rs

@@ -145,7 +145,7 @@ impl DataSink for MySQLDataSink {
             num_rows += batch_num_rows as u64;
 
             constraints::validate_batch_with_constraints(
-                &[batch.clone()],
+                std::slice::from_ref(&batch),
                 self.mysql.constraints(),
             )
             .await

core/src/postgres/write.rs

@@ -204,7 +204,7 @@ impl DataSink for PostgresDataSink {
             num_rows += batch_num_rows as u64;
 
             constraints::validate_batch_with_constraints(
-                &[batch.clone()],
+                std::slice::from_ref(&batch),
                 self.postgres.constraints(),
             )
             .await

core/src/sql/db_connection_pool/dbconnection.rs

@@ -237,6 +237,6 @@ pub async fn query_arrow<T, P>(
             .await
             .context(UnableToQueryArrowSnafu {})
     } else {
-        return Err(Error::UnableToDowncastConnection {});
+        Err(Error::UnableToDowncastConnection {})
     }
 }

core/src/sql/db_connection_pool/dbconnection/odbcconn.rs

@@ -66,7 +66,7 @@ impl<T: InputParameter + Sync + Send + DynClone> ODBCSyncParameter for T {
 dyn_clone::clone_trait_object!(ODBCSyncParameter);
 
 pub type ODBCParameter = Box<dyn ODBCSyncParameter>;
-pub type ODBCDbConnection<'a> = (dyn DbConnection<Connection<'a>, ODBCParameter>);
+pub type ODBCDbConnection<'a> = dyn DbConnection<Connection<'a>, ODBCParameter>;
 pub type ODBCDbConnectionPool<'a> =
     dyn DbConnectionPool<Connection<'a>, ODBCParameter> + Sync + Send;
 
@@ -142,7 +142,6 @@ where
         unimplemented!()
     }
 
-    #[must_use]
     async fn get_schema(
         &self,
         table_reference: &TableReference,

core/src/sqlite/federation.rs

@@ -56,7 +56,7 @@ fn sqlite_ast_analyzer(ast: ast::Statement) -> Result<ast::Statement, DataFusion
             // iterate over the query and find any INTERVAL statements
             // find the column they target, and replace the INTERVAL and column with e.g. datetime(column, '+1 day')
             let mut interval_visitor = SQLiteIntervalVisitor::default();
-            new_query.visit(&mut interval_visitor);
+            let _ = new_query.visit(&mut interval_visitor);
 
             Ok(ast::Statement::Query(new_query))
         }

core/src/sqlite/write.rs

@@ -166,10 +166,13 @@ impl DataSink for SqliteDataSink {
                     DataFusionError::Execution(format!("Unable to convert num_rows() to u64: {e}"))
                 })?;
 
-                constraints::validate_batch_with_constraints(&[data_batch.clone()], &constraints)
-                    .await
-                    .context(super::ConstraintViolationSnafu)
-                    .map_err(to_datafusion_error)?;
+                constraints::validate_batch_with_constraints(
+                    std::slice::from_ref(&data_batch),
+                    &constraints,
+                )
+                .await
+                .context(super::ConstraintViolationSnafu)
+                .map_err(to_datafusion_error)?;
 
                 batch_tx.send(data_batch).await.map_err(|err| {
                     DataFusionError::Execution(format!("Error sending data batch: {err}"))

rust-toolchain.toml

@@ -1,3 +1,3 @@
 [toolchain]
-channel = "1.86.0"
+channel = "1.89.0"
 components = ["rustc", "cargo", "rustfmt", "clippy"]