chore: make clippy happy (#52)

Author: WenyXu

benches/arrow_reader.rs

@@ -23,7 +23,7 @@ use orc_rust::arrow_reader::ArrowReaderBuilder;
 
 fn basic_path(path: &str) -> String {
     let dir = env!("CARGO_MANIFEST_DIR");
-    format!("{}/tests/basic/data/{}", dir, path)
+    format!("{dir}/tests/basic/data/{path}")
 }
 
 // demo-12-zlib.orc

src/arrow_writer.rs

@@ -350,7 +350,7 @@ mod tests {
         )
         .unwrap();
 
-        let rows = roundtrip(&[batch.clone()]);
+        let rows = roundtrip(std::slice::from_ref(&batch));
         assert_eq!(batch, rows[0]);
     }
 

src/compression.rs

@@ -96,7 +96,7 @@ pub enum CompressionType {
 
 impl std::fmt::Display for CompressionType {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
-        write!(f, "{:?}", self)
+        write!(f, "{self:?}")
     }
 }
 

src/lib.rs

@@ -53,10 +53,12 @@ pub mod arrow_writer;
 pub mod async_arrow_reader;
 mod column;
 pub mod compression;
+#[allow(dead_code)]
 mod encoding;
 pub mod error;
 mod memory;
 pub mod projection;
+#[allow(dead_code)]
 mod proto;
 pub mod reader;
 pub mod schema;

src/schema.rs

@@ -133,8 +133,7 @@ fn parse_struct_children_from_proto(
         ty.subtypes.len() == ty.field_names.len(),
         UnexpectedSnafu {
             msg: format!(
-                "Struct type for column index {} must have matching lengths for subtypes and field names lists",
-                column_index,
+                "Struct type for column index {column_index} must have matching lengths for subtypes and field names lists"
             )
         }
     );

tests/basic/main.rs

@@ -77,7 +77,7 @@ fn new_arrow_reader_range(path: &str, range: Range<usize>) -> ArrowReader<File>
 
 fn basic_path(path: &str) -> String {
     let dir = env!("CARGO_MANIFEST_DIR");
-    format!("{}/tests/basic/data/{}", dir, path)
+    format!("{dir}/tests/basic/data/{path}")
 }
 
 #[test]
@@ -617,7 +617,7 @@ pub fn decimal128_timestamps_test() {
 
 fn integration_path(path: &str) -> String {
     let dir = env!("CARGO_MANIFEST_DIR");
-    format!("{}/tests/integration/data/{}", dir, path)
+    format!("{dir}/tests/integration/data/{path}")
 }
 
 // TODO: Move this to integration test file. Placed here because it has access to assert_batches_eq.
@@ -661,7 +661,6 @@ pub fn assert_batches_eq(batches: &[RecordBatch], expected_lines: &[&str]) {
     let actual_lines: Vec<_> = formatted.trim().lines().collect();
     assert_eq!(
         &actual_lines, expected_lines,
-        "\n\nexpected:\n\n{:#?}\nactual:\n\n{:#?}\n\n",
-        expected_lines, actual_lines
+        "\n\nexpected:\n\n{expected_lines:#?}\nactual:\n\n{actual_lines:#?}\n\n"
     );
 }