Merge pull request #65 from drscholly/fix/rdv

Ignore ReferenceDataValue links for now

Author: drscholly

toolbox/api/datagalaxy_api_modules.py

@@ -28,10 +28,11 @@ def __init__(self, url: str, token: str, workspace: dict, module: str):
 
     def list_objects(self, workspace_name: str, include_links=False) -> list:
         version_id = self.workspace['defaultVersionId']
+        params = {'versionId': version_id, 'limit': '5000'}
         if include_links is True:
-            params = {'versionId': version_id, 'limit': '5000', 'includeLinks': 'true'}
+            params['includeLinks'] = 'true'
         else:
-            params = {'versionId': version_id, 'limit': '5000', 'includeAttributes': 'true'}
+            params['includeAttributes'] = 'true'
         headers = {'Authorization': f"Bearer {self.token}"}
         response = requests.get(f"{self.url}/{self.route}", params=params, headers=headers)
         code = response.status_code
@@ -214,7 +215,7 @@ def bulk_upsert_source_tree(self, workspace_name: str, source: dict, objects: li
 
     def delete_objects(self, workspace_name: str, ids: list) -> int:
         if len(ids) < 1:
-            logging.warn(f'Nothing to delete on workspace "{workspace_name}" in module {self.module}, aborting.')
+            logging.warning(f'Nothing to delete on workspace "{workspace_name}" in module {self.module}, aborting.')
             return 0
         version_id = self.workspace['defaultVersionId']
         headers = {'Authorization': f"Bearer {self.token}"}

toolbox/commands/copy_links.py

@@ -117,10 +117,21 @@ def parse_links(obj: dict) -> list:
     # DPI are ignored since they are handled differently
     if "DataProcessingItem" in obj["typePath"]:
         return []
+    # ReferenceDataValue have to be ignored (at least for now)
+    if "ReferenceDataValue" in obj["typePath"]:
+        return []
     for key in obj["links"]:
         for dest in obj["links"][key]:
             if "DataProcessingItem" in dest["typePath"]:
                 continue
+            if "ReferenceDataValue" in dest["typePath"]:
+                logging.warning('The following link cannot be created with the API, please create it manually:')
+                logging.warning(obj["path"])
+                logging.warning(obj["typePath"])
+                logging.warning(key)
+                logging.warning(dest["path"])
+                logging.warning(dest["typePath"])
+                continue
             link = {
                     'fromPath': obj["path"],
                     'fromType': obj["typePath"],
@@ -132,6 +143,24 @@ def parse_links(obj: dict) -> list:
     return links
 
 
+# This is a WIP and not used yet in the codebase
+def handle_reference_data_value(source_glossary: list) -> str:
+    for page in source_glossary:
+        page_index = source_glossary.index(page)
+        for glossary_object in page:
+            go_index = page.index(glossary_object)
+            if glossary_object['type'] == 'ReferenceDataValue' and glossary_object['links']:
+                if 'attributes' in glossary_object and 'code' in glossary_object['attributes']:
+                    new_path = glossary_object['path'] + '\\' + glossary_object['attributes']['code']
+                    new_type_path = glossary_object['typePath'].replace('\\ReferenceDataValue', '\\Value\\ValueCode')
+                    page[go_index]['path'] = new_path
+                    page[go_index]['typePath'] = new_type_path
+                else:
+                    logging.warning(f'Links of Reference Data Value {glossary_object["technicalName"]} cannot be imported without editor attribute Code')
+                    logging.warning('Please add it to your DataGalaxy screen for Reference Data Value objects')
+        source_glossary[page_index] = page
+
+
 def copy_links_parse(subparsers):
     # create the parser for the "copy_links" command
     copy_links_parse = subparsers.add_parser('copy-links', help='copy-links help')