Skip to content

Commit 1be9717

Browse files
committed
Show load options on failure, close connection after ping in to_sql
1 parent b4e9c7e commit 1be9717

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

dataflows/processors/dumpers/to_sql.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,9 @@ def __init__(self,
6363
"Please set your '%s' environment variable" % env_var)
6464

6565
self.engine = create_engine(engine)
66-
self.engine.connect()
66+
# check connection
67+
with self.engine.connect():
68+
pass
6769
else:
6870
self.engine = engine
6971

dataflows/processors/load.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,13 @@ def __init__(self, load_source, name=None, resources=None, strip=True, limit_row
157157
}[cast_strategy or self.CAST_DO_NOTHING]
158158

159159
def process_datapackage(self, dp: Package):
160+
try:
161+
return self.safe_process_datapackage(dp)
162+
except Exception as e:
163+
raise e from Exception('Failed to run load with load source {!r} and options {!r}'
164+
.format(self.load_source, self.options))
165+
166+
def safe_process_datapackage(self, dp: Package):
160167

161168
# If loading from datapackage & resource iterator:
162169
if isinstance(self.load_source, tuple):

0 commit comments

Comments
 (0)