Temporal format property fix (#117)

* Extended the existing test

* Fixed for time fields

Author: roll

data/temporal.csv

@@ -1,3 +1,3 @@
-date,event
-2015-01-02,start
-2016-06-25,finish
+event,datetime,date,time
+start,2015-01-02T15:30:45,2015-01-02,15:30:45
+end,2016-06-25T08:10:04,2016-06-25,08:10:04

dataflows/processors/dumpers/file_formats.py

@@ -42,7 +42,8 @@ def __init__(self, writer, schema, temporal_format_property=None):
                 if field.type in ['datetime', 'date', 'time']:
                     format = field.descriptor.get(self.temporal_format_property, None)
                     if format:
-                        serializer = partial(datetime.datetime.strftime, format=format)
+                        strftime = getattr(datetime, field.type).strftime
+                        serializer = partial(strftime, format=format)
             field.descriptor['serializer'] = serializer
 
     @classmethod

tests/test_lib.py

@@ -1420,7 +1420,11 @@ def test_force_temporal_format():
     Flow(
         load('data/temporal.csv',
             name='temporal',
-            override_fields={'date': {'outputFormat': '%m/%d/%y'}}),
+            override_fields={
+                'datetime': {'type': 'datetime', 'outputFormat': '%y|%m|%d %H|%M|%S'},
+                'date': {'outputFormat': '%y|%m|%d'},
+                'time': {'outputFormat': '%H|%M|%S'},
+            }),
         dump_to_path('out/force_temporal_format',
             temporal_format_property='outputFormat')
     ).process()
@@ -1434,12 +1438,24 @@ def test_force_temporal_format():
     # Assert
     assert package.descriptor['resources'][0]['schema'] == {
         'fields': [
-            {'format': '%m/%d/%y', 'name': 'date', 'type': 'date'},
-            {'format': 'default', 'name': 'event', 'type': 'string'}
+            {'format': 'default', 'name': 'event', 'type': 'string'},
+            {'format': '%y|%m|%d %H|%M|%S', 'name': 'datetime', 'type': 'datetime'},
+            {'format': '%y|%m|%d', 'name': 'date', 'type': 'date'},
+            {'format': '%H|%M|%S', 'name': 'time', 'type': 'time'},
         ],
         'missingValues': [''],
     }
     assert data == [[
-        {'date': datetime.date(2015, 1, 2), 'event': 'start'},
-        {'date': datetime.date(2016, 6, 25), 'event': 'finish'}
+        {
+            'event': 'start',
+            'datetime': datetime.datetime(2015, 1, 2, 15, 30, 45),
+            'date': datetime.date(2015, 1, 2),
+            'time': datetime.time(15, 30, 45),
+        },
+        {
+            'event': 'end',
+            'datetime': datetime.datetime(2016, 6, 25, 8, 10, 4),
+            'date': datetime.date(2016, 6, 25),
+            'time': datetime.time(8, 10, 4),
+        }
     ]]