Skip to content

Commit 81310f7

Browse files
fix(ui): Minor UX improvements for Query Tab (#15074)
1 parent a7f1c6b commit 81310f7

File tree

4 files changed

+8
-11
lines changed

4 files changed

+8
-11
lines changed

datahub-web-react/src/app/entityV2/shared/containers/profile/sidebar/shared/TopUsersFacepile.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,10 @@ export type Props = {
1515
};
1616

1717
export default function TopUsersFacepile({ users, max, checkExistence = true }: Props) {
18+
const entityRegistry = useEntityRegistry();
1819
const displayedUsers = users.filter((user) => userExists(user));
1920
const usersList = checkExistence ? displayedUsers : users;
20-
const entityRegistry = useEntityRegistry();
21+
if (!usersList?.length) return <div>-</div>;
2122
return (
2223
<Avatar.Group maxCount={max}>
2324
{usersList?.map((user) => {

datahub-web-react/src/app/entityV2/shared/tabs/Dataset/Queries/QueriesListSection.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ export default function QueriesListSection({
141141
createdByColumn,
142142
createdDateColumn,
143143
powersColumn,
144-
usedByColumn,
144+
topUsersColumn,
145145
columnsColumn,
146146
editColumn,
147147
} = useQueryTableColumns({
@@ -165,7 +165,7 @@ export default function QueriesListSection({
165165
editColumn,
166166
];
167167

168-
const popularQueriesColumns = [queryTextColumn(), usedByColumn, columnsColumn];
168+
const popularQueriesColumns = [queryTextColumn(), topUsersColumn, columnsColumn];
169169

170170
const downstreamQueriesColumns = [queryTextColumn(550), powersColumn];
171171

datahub-web-react/src/app/entityV2/shared/tabs/Dataset/Queries/queryColumns.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -180,13 +180,9 @@ interface ColumnProps {
180180
query: Query;
181181
}
182182

183-
const ColumnsWrapper = styled.div`
184-
text-align: right;
185-
`;
186-
187183
/*
188184
* Columns Column
189185
*/
190186
export const ColumnsColumn = ({ query }: ColumnProps) => {
191-
return <ColumnsWrapper>{query.columns?.length ?? 0}</ColumnsWrapper>;
187+
return <div>{query.columns?.length ?? 0}</div>;
192188
};

datahub-web-react/src/app/entityV2/shared/tabs/Dataset/Queries/useQueryTableColumns.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,8 +145,8 @@ export default function useQueryTableColumns({
145145
},
146146
};
147147

148-
const usedByColumn = {
149-
title: 'Used By',
148+
const topUsersColumn = {
149+
title: 'Top Users',
150150
dataIndex: 'usedBy',
151151
key: 'usedBy',
152152
className: 'usedBy',
@@ -195,7 +195,7 @@ export default function useQueryTableColumns({
195195
createdByColumn,
196196
createdDateColumn,
197197
powersColumn,
198-
usedByColumn,
198+
topUsersColumn,
199199
columnsColumn,
200200
editColumn,
201201
};

0 commit comments

Comments
 (0)