Fixed some UX and React reconciliation errors on Tags page (#15098)

Author: ani-malgari

datahub-frontend/test/app/ApplicationTest.java

@@ -940,12 +940,12 @@ public void testHappyPathOidc() throws ParseException {
     assertEquals(TEST_USER, data.get("actor"));
     // Default expiration is 24h, so should always be less than current time + 1 day since it stamps
     // the time before this executes. Use a more generous tolerance to account for timezone
-    // differences
-    // and test execution time variations.
+    // differences, DST transitions, and test execution time variations.
+    // Increased tolerance to 22-26 hours to handle DST transitions (which can cause 1-hour shifts)
     Date maxExpectedExpiration =
-        new Date(System.currentTimeMillis() + (25 * 60 * 60 * 1000)); // 25 hours
+        new Date(System.currentTimeMillis() + (26 * 60 * 60 * 1000)); // 26 hours
     Date minExpectedExpiration =
-        new Date(System.currentTimeMillis() + (23 * 60 * 60 * 1000)); // 23 hours
+        new Date(System.currentTimeMillis() + (22 * 60 * 60 * 1000)); // 22 hours
     Date actualExpiration = claims.getExpirationTime();
 
     assertTrue(

datahub-web-react/src/alchemy-components/components/Table/Table.tsx

@@ -195,10 +195,9 @@ export const Table = <T,>({
                         const canExpand = expandable?.rowExpandable?.(row); // Check if row is expandable
                         const key = `row-${index}-${sortColumn ?? 'none'}-${sortOrder ?? 'none'}`;
                         return (
-                            <>
+                            <React.Fragment key={key}>
                                 {/* Render the main row */}
                                 <TableRow
-                                    key={key}
                                     canExpand={canExpand}
                                     onClick={(e) => {
                                         if (focusedRowIndex === index) {
@@ -298,7 +297,7 @@ export const Table = <T,>({
                                         </TableCell>
                                     </TableRow>
                                 )}
-                            </>
+                            </React.Fragment>
                         );
                     })}
                     {footer}

datahub-web-react/src/app/homeV2/layout/navBarRedesign/NavBarMenu.tsx

@@ -72,7 +72,9 @@ export default function NavBarMenu({ menu, selectedKey, isCollapsed, iconSize, s
 
     return (
         <StyledMenu selectedKeys={selectedKey ? [selectedKey] : []} style={style} data-testid="nav-menu-links">
-            {menu.items.map((item) => renderMenuItem(item))}
+            {menu.items.map((item) => (
+                <React.Fragment key={item.key}>{renderMenuItem(item)}</React.Fragment>
+            ))}
         </StyledMenu>
     );
 }

datahub-web-react/src/app/ingestV2/source/__tests__/tests_utils.test.tsx

@@ -567,7 +567,7 @@ describe('formatTimezone', () => {
         expect(['EST', 'EDT']).toContain(nycAbbr);
 
         const londonAbbr = formatTimezone('Europe/London');
-        expect(['GMT+1', 'BST', 'GMT']).toContain(londonAbbr);
+        expect(['GMT', 'BST']).toContain(londonAbbr);
 
         // Tokyo doesn't observe DST, so it's always GMT+9
         expect(formatTimezone('Asia/Tokyo')).toBe('GMT+9');

datahub-web-react/src/app/tags/CreateNewTagModal/CreateNewTagModal.tsx

@@ -103,7 +103,7 @@ const CreateNewTagModal: React.FC<CreateNewTagModalProps> = ({ onClose, open })
             setSelectedOwnerUrns([]);
         } catch (e: any) {
             message.destroy();
-            message.error('Failed to create tag. An unexpected error occurred');
+            message.error(`Failed to create tag. ${e.message}`);
         } finally {
             setIsLoading(false);
         }
@@ -136,7 +136,15 @@ const CreateNewTagModal: React.FC<CreateNewTagModalProps> = ({ onClose, open })
     ];
 
     return (
-        <Modal title="Create New Tag" onCancel={onClose} buttons={buttons} open={open} centered width={500}>
+        <Modal
+            title="Create New Tag"
+            onCancel={onClose}
+            buttons={buttons}
+            open={open}
+            centered
+            width={500}
+            dataTestId="create-tag-modal"
+        >
             {/* Tag Details Section */}
             <TagDetailsSection
                 tagName={tagName}

smoke-test/tests/cypress/cypress/e2e/manage_tagsV2/helpers/tags_page_helper.js

@@ -18,9 +18,11 @@ export default class TagsPageHelper {
     cy.clickOptionWithTestId("create-tag-modal-create-button");
 
     if (shouldBeSuccessfullyCreated) {
-      cy.waitTextVisible(`Tag "${name}" successfully created`);
+      // Wait for modal to close - check that add button is available again
+      cy.getWithTestId("add-tag-button").should("be.visible");
     } else {
-      cy.waitTextVisible("Failed to create tag. An unexpected error occurred");
+      // Wait for any error message that starts with "Failed to create tag."
+      cy.contains(/Failed to create tag\./).should("be.visible");
       cy.clickOptionWithTestId("create-tag-modal-cancel-button");
     }
   }