fix(web): tsc null check (#15109)

jayacryl · web-flow · commit bc25b82da52f · 2025-10-25T11:55:36.000-07:00
diff --git a/datahub-web-react/src/app/entity/dataset/shared/utils.ts b/datahub-web-react/src/app/entity/dataset/shared/utils.ts
@@ -5,7 +5,7 @@ export function getLastUpdatedMs(
     operations: Pick<Operation, 'lastUpdatedTimestamp'>[] | null | undefined,
 ): number | undefined {
     return (
-        Math.max(
+        Math?.max(
             properties?.lastModified?.time || 0,
             (operations?.length && operations[0].lastUpdatedTimestamp) || 0,
         ) || undefined
diff --git a/datahub-web-react/src/app/entityV2/shared/components/styled/search/__tests__/downloadAsCsvUtil.test.ts b/datahub-web-react/src/app/entityV2/shared/components/styled/search/__tests__/downloadAsCsvUtil.test.ts
@@ -10,7 +10,7 @@ import { EntityType } from '@types';
 
 // Mock external dependencies
 vi.mock('@app/shared/textUtil', () => ({
-    capitalizeFirstLetterOnly: vi.fn((str: string) => str?.charAt(0).toUpperCase() + str?.slice(1).toLowerCase()),
+    capitalizeFirstLetterOnly: vi.fn((str: string) => str?.charAt(0)?.toUpperCase() + str?.slice(1).toLowerCase()),
 }));
 
 vi.mock('@utils/runtimeBasePath', () => ({
diff --git a/datahub-web-react/src/app/entityV2/shared/tabs/Incident/AcrylComponents/IncidentEditor.tsx b/datahub-web-react/src/app/entityV2/shared/tabs/Incident/AcrylComponents/IncidentEditor.tsx
@@ -47,7 +47,7 @@ export const IncidentEditor = ({
         data?.title?.length &&
             data?.description &&
             data?.type &&
-            (data?.type !== IncidentType.Custom || data?.customType),
+            (data?.type !== IncidentType?.Custom || data?.customType),
     );
     const { user } = useUserContext();
     const userHasChangedState = useRef(false);
diff --git a/datahub-web-react/src/app/entityV2/summary/properties/property/properties/structuredProperty/StructuredPropertyProperty.tsx b/datahub-web-react/src/app/entityV2/summary/properties/property/properties/structuredProperty/StructuredPropertyProperty.tsx
@@ -22,7 +22,7 @@ export default function StructuredPropertyProperty(props: PropertyComponentProps
         );
     }, [property.structuredProperty?.urn, entityData]);
 
-    const valueType = structuredPropertyEntry?.structuredProperty.definition.valueType.urn;
+    const valueType = structuredPropertyEntry?.structuredProperty?.definition?.valueType?.urn;
 
     const StructuredPropertyComponent = useMemo(() => {
         switch (valueType) {
diff --git a/datahub-web-react/src/app/entityV2/summary/properties/property/properties/structuredProperty/components/NumberStructuredProperty.tsx b/datahub-web-react/src/app/entityV2/summary/properties/property/properties/structuredProperty/components/NumberStructuredProperty.tsx
@@ -11,7 +11,7 @@ export default function NumberStructuredProperty({
     ...props
 }: StructuredPropertyComponentProps) {
     const values = useMemo(
-        () => structuredPropertyEntry?.values.map((value) => (value as NumberValue)?.numberValue) ?? [],
+        () => structuredPropertyEntry?.values?.map((value) => (value as NumberValue)?.numberValue) ?? [],
         [structuredPropertyEntry?.values],
     );
 
diff --git a/datahub-web-react/src/app/entityV2/summary/properties/property/properties/structuredProperty/components/StringStructuredProperty.tsx b/datahub-web-react/src/app/entityV2/summary/properties/property/properties/structuredProperty/components/StringStructuredProperty.tsx
@@ -11,7 +11,7 @@ export default function StringStructuredProperty({
     ...props
 }: StructuredPropertyComponentProps) {
     const values = useMemo(
-        () => structuredPropertyEntry?.values.map((value) => (value as StringValue)?.stringValue) ?? [],
+        () => structuredPropertyEntry?.values?.map((value) => (value as StringValue)?.stringValue) ?? [],
         [structuredPropertyEntry?.values],
     );
 
diff --git a/datahub-web-react/src/app/homeV3/modules/assetCollection/AssetCollectionModal.tsx b/datahub-web-react/src/app/homeV3/modules/assetCollection/AssetCollectionModal.tsx
@@ -24,7 +24,7 @@ const AssetCollectionModal = () => {
         moduleModalState: { position, close, isEditing, initialState },
     } = usePageTemplateContext();
     const [form] = Form.useForm();
-    const currentName = initialState?.properties.name || '';
+    const currentName = initialState?.properties?.name || '';
     const currentAssets = (initialState?.properties?.params?.assetCollectionParams?.assetUrns || []).filter(
         (urn): urn is string => typeof urn === 'string',
     );
diff --git a/datahub-web-react/src/app/homeV3/modules/documentation/DocumentationModal.tsx b/datahub-web-react/src/app/homeV3/modules/documentation/DocumentationModal.tsx
@@ -22,7 +22,7 @@ const DocumentationModal = () => {
         moduleModalState: { position, close, isEditing, initialState },
     } = usePageTemplateContext();
     const [form] = Form.useForm();
-    const currentName = initialState?.properties.name || '';
+    const currentName = initialState?.properties?.name || '';
     const currentContent = initialState?.properties?.params?.richTextParams?.content;
     const urn = initialState?.urn;
 
diff --git a/datahub-web-react/src/app/homeV3/modules/hierarchyViewModule/HierarchyViewModal.tsx b/datahub-web-react/src/app/homeV3/modules/hierarchyViewModule/HierarchyViewModal.tsx
@@ -20,19 +20,19 @@ export default function HierarchyViewModal() {
     const [form] = Form.useForm<HierarchyForm>();
 
     const initialFormState: HierarchyForm = useMemo(() => {
-        const originalAssetUrns = initialState?.properties.params.hierarchyViewParams?.assetUrns;
+        const originalAssetUrns = initialState?.properties?.params?.hierarchyViewParams?.assetUrns;
         const assetType = getAssetTypeFromAssetUrns(originalAssetUrns);
         const assetUrns = filterAssetUrnsByAssetType(originalAssetUrns, assetType);
 
         const relatedEntitiesFilterJson =
-            initialState?.properties.params.hierarchyViewParams?.relatedEntitiesFilterJson;
+            initialState?.properties?.params?.hierarchyViewParams?.relatedEntitiesFilterJson;
 
         return {
-            name: initialState?.properties.name || '',
+            name: initialState?.properties?.name || '',
             assetsType: assetType,
             domainAssets: assetType === ASSET_TYPE_DOMAINS ? assetUrns : [],
             glossaryAssets: assetType === ASSET_TYPE_GLOSSARY ? assetUrns : [],
-            showRelatedEntities: !!initialState?.properties.params.hierarchyViewParams?.showRelatedEntities,
+            showRelatedEntities: !!initialState?.properties?.params?.hierarchyViewParams?.showRelatedEntities,
             relatedEntitiesFilter: relatedEntitiesFilterJson ? JSON.parse(relatedEntitiesFilterJson) : undefined,
         };
     }, [initialState]);
diff --git a/datahub-web-react/src/app/homeV3/modules/hierarchyViewModule/components/domains/hooks/useDomains.ts b/datahub-web-react/src/app/homeV3/modules/hierarchyViewModule/components/domains/hooks/useDomains.ts
@@ -34,7 +34,7 @@ export default function useDomains(parentDomainUrn: string | undefined, start: n
 
     const domains = useMemo(() => {
         if (skip) return [];
-        return data?.searchAcrossEntities?.searchResults.map((result) => result.entity).filter(isDomain);
+        return data?.searchAcrossEntities?.searchResults?.map((result) => result.entity).filter(isDomain);
     }, [data, skip]);
 
     const total = useMemo(() => data?.searchAcrossEntities?.total, [data]);
diff --git a/datahub-web-react/src/app/homeV3/modules/link/LinkModal.tsx b/datahub-web-react/src/app/homeV3/modules/link/LinkModal.tsx
@@ -21,7 +21,7 @@ export default function LinkModal() {
         moduleModalState: { position, close, isEditing, initialState },
     } = usePageTemplateContext();
     const [form] = Form.useForm();
-    const currentName = initialState?.properties.name || '';
+    const currentName = initialState?.properties?.name || '';
     const linkParams = initialState?.properties?.params?.linkParams;
     const urn = initialState?.urn;
 
diff --git a/datahub-web-react/src/app/homeV3/template/components/addModuleMenu/utils.ts b/datahub-web-react/src/app/homeV3/template/components/addModuleMenu/utils.ts
@@ -4,7 +4,7 @@ import { PageModuleFragment, PageTemplateFragment } from '@graphql/template.gene
 
 export function getCustomGlobalModules(globalTemplate: PageTemplateFragment | null) {
     const customGlobalModules: PageModuleFragment[] = [];
-    globalTemplate?.properties.rows.forEach((row) => {
+    globalTemplate?.properties?.rows?.forEach((row) => {
         row.modules.forEach((module) => {
             if (CUSTOM_MODULE_TYPES.includes(module.properties.type)) {
                 customGlobalModules.push(module);
diff --git a/datahub-web-react/src/app/ingestV2/source/IngestionSourceList.tsx b/datahub-web-react/src/app/ingestV2/source/IngestionSourceList.tsx
@@ -682,7 +682,7 @@ export const IngestionSourceList = ({
                                 onDelete={onDelete}
                                 onChangeSort={onChangeSort}
                                 isLoading={
-                                    loading && (!data || data?.listIngestionSources?.ingestionSources.length === 0)
+                                    loading && (!data || data?.listIngestionSources?.ingestionSources?.length === 0)
                                 }
                                 shouldPreserveParams={shouldPreserveParams}
                                 isLastPage={isLastPage}
diff --git a/datahub-web-react/src/app/lineageV2/useBulkEntityLineage.ts b/datahub-web-react/src/app/lineageV2/useBulkEntityLineage.ts
@@ -97,7 +97,8 @@ export default function useBulkEntityLineage(shownUrns: string[]): (urn: string)
             endTimeMillis,
             separateSiblings: true,
             showColumns: true,
-            includeGhostEntities: showGhostEntities || (rootType === EntityType.SchemaField && ignoreSchemaFieldStatus),
+            includeGhostEntities:
+                showGhostEntities || (rootType === EntityType?.SchemaField && ignoreSchemaFieldStatus),
         },
         onCompleted: (data) => {
             const smallContext = { nodes, edges, adjacencyList, setDisplayVersion };
diff --git a/datahub-web-react/src/app/lineageV3/LineageEntityNode/NodeContents.tsx b/datahub-web-react/src/app/lineageV3/LineageEntityNode/NodeContents.tsx
@@ -297,7 +297,7 @@ function NodeContents(props: Props & LineageEntity & DisplayedColumns) {
         const lastRun = entity?.genericEntityProperties?.lastRun;
         const lastRunEvent = entity?.genericEntityProperties?.lastRunEvent;
 
-        const time = lastRun?.properties?.created.time || lastRun?.created?.time;
+        const time = lastRun?.properties?.created?.time || lastRun?.created?.time;
         if (time) {
             extraDetails = (
                 <DataJobLastRunWrapper>
diff --git a/datahub-web-react/src/app/lineageV3/initialize/useFetchChildDataJobs.ts b/datahub-web-react/src/app/lineageV3/initialize/useFetchChildDataJobs.ts
@@ -30,14 +30,14 @@ export default function useFetchChildDataJobs(): boolean {
             let addedNode = false;
 
             const jobs = data.dataFlow?.childJobs;
-            jobs?.relationships.forEach((job) => {
+            jobs?.relationships?.forEach((job) => {
                 if (!job.entity) return;
                 addedNode = addedNode || !nodes.has(job.entity.urn);
                 const node = setDefault(nodes, job.entity.urn, makeInitialNode(job.entity));
                 node.parentDataJob = rootUrn;
 
                 if (job.entity.__typename === 'DataJob') {
-                    job.entity.upstream?.relationships.forEach((relationship) => {
+                    job.entity.upstream?.relationships?.forEach((relationship) => {
                         if (!relationship.entity) return;
                         const edgeId = getEdgeId(node.urn, relationship.entity.urn, LineageDirection.Upstream);
                         edges.set(edgeId, { ...edges.get(edgeId), isDisplayed: true });
diff --git a/datahub-web-react/src/app/lineageV3/queries/useBulkEntityLineage.ts b/datahub-web-react/src/app/lineageV3/queries/useBulkEntityLineage.ts
@@ -97,7 +97,8 @@ export default function useBulkEntityLineage(shownUrns: string[]): (urn: string)
             endTimeMillis,
             separateSiblings: true,
             showColumns: true,
-            includeGhostEntities: showGhostEntities || (rootType === EntityType.SchemaField && ignoreSchemaFieldStatus),
+            includeGhostEntities:
+                showGhostEntities || (rootType === EntityType?.SchemaField && ignoreSchemaFieldStatus),
         },
         onCompleted: (data) => {
             const smallContext = { nodes, edges, adjacencyList, setDisplayVersion, rootType };
diff --git a/datahub-web-react/src/app/lineageV3/useComputeGraph/__tests__/NodeBuilder.test.ts b/datahub-web-react/src/app/lineageV3/useComputeGraph/__tests__/NodeBuilder.test.ts
@@ -225,10 +225,10 @@ describe('NodeBuilder', () => {
         expect(dataset1Node?.position.x).toEqual(dataset2Node?.position.x);
         expect(dataset1Node?.position.y).toBeLessThan(dataset2Node?.position.y ?? -Infinity);
         expect(transform1Node?.position.x).toBeGreaterThan(dataset1Node?.position.x ?? Infinity);
-        expect(dataset4Node?.position.y).toEqual(dataset5Node?.position.y);
+        expect(dataset4Node?.position?.y).toEqual(dataset5Node?.position.y);
         expect(transform2Node?.position.y).within(
-            (dataset4Node?.position.y || 0) - 20,
-            (dataset4Node?.position.y || 0) + 20,
+            (dataset4Node?.position?.y || 0) - 20,
+            (dataset4Node?.position?.y || 0) + 20,
         );
         expect(dataset5Node?.position.x).toBeLessThan(transform2Node?.position.x ?? -Infinity);
         expect(dataset4Node?.position.x).toBeGreaterThan(transform2Node?.position.x ?? Infinity);
diff --git a/datahub-web-react/src/app/shared/hooks/useFileUpload.ts b/datahub-web-react/src/app/shared/hooks/useFileUpload.ts
@@ -32,8 +32,8 @@ export default function useFileUpload({ scenario, assetUrn, schemaField }: Props
             },
         });
 
-        const uploadUrl = data?.getPresignedUploadUrl.url;
-        const fileId = data?.getPresignedUploadUrl.fileId;
+        const uploadUrl = data?.getPresignedUploadUrl?.url;
+        const fileId = data?.getPresignedUploadUrl?.fileId;
 
         if (!uploadUrl) {
             throw new Error('Issue uploading file to server');
