fix(authorization): fix restricted entity privmitives (#10265)

Author: david-leifker

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/authorization/AuthorizationUtils.java

@@ -285,7 +285,8 @@ public static <T> T restrictEntity(@Nonnull Object entity, Class<T> clazz) {
                     // they are a `one of` non-null.
                     // i.e. ChartProperties or ChartEditableProperties are required.
                     if (field.getAnnotation(javax.annotation.Nonnull.class) != null
-                        || field.getName().toLowerCase().contains("properties")) {
+                        || field.getName().toLowerCase().contains("properties")
+                        || field.getType().isPrimitive()) {
                       try {
                         switch (field.getName()) {
                             // pass through to the restricted entity
@@ -303,21 +304,32 @@ public static <T> T restrictEntity(@Nonnull Object entity, Class<T> clazz) {
                             return fieldGetter.invoke(entity, (Object[]) null);
                           default:
                             switch (field.getType().getSimpleName()) {
+                              case "boolean":
                               case "Boolean":
                                 Method boolGetter =
                                     MethodUtils.getMatchingMethod(
                                         entity.getClass(),
                                         "get" + StringUtils.capitalise(field.getName()));
-                                return boolGetter.invoke(entity, (Object[]) null);
+                                return Boolean.TRUE.equals(
+                                    boolGetter.invoke(entity, (Object[]) null));
                                 // mask these fields in the restricted entity
+                              case "char":
                               case "String":
                                 return "";
+                              case "short":
+                              case "Short":
+                              case "int":
                               case "Integer":
                                 return 0;
+                              case "long":
                               case "Long":
                                 return 0L;
+                              case "float":
+                              case "Float":
+                                return 0F;
+                              case "double":
                               case "Double":
-                                return 0.0;
+                                return 0D;
                               case "List":
                                 return List.of();
                               default:

datahub-graphql-core/src/test/java/com/linkedin/datahub/graphql/authorization/AuthorizationUtilsTest.java

@@ -0,0 +1,33 @@
+package com.linkedin.datahub.graphql.authorization;
+
+import static org.testng.Assert.assertEquals;
+
+import com.linkedin.datahub.graphql.generated.ViewProperties;
+import org.testng.annotations.Test;
+
+public class AuthorizationUtilsTest {
+
+  @Test
+  public void testRestrictedViewProperties() {
+    // provides a test of primitive boolean
+    ViewProperties viewProperties =
+        ViewProperties.builder()
+            .setMaterialized(true)
+            .setLanguage("testLang")
+            .setFormattedLogic("formattedLogic")
+            .setLogic("testLogic")
+            .build();
+
+    String expected =
+        ViewProperties.builder()
+            .setMaterialized(true)
+            .setLanguage("")
+            .setLogic("")
+            .build()
+            .toString();
+
+    assertEquals(
+        AuthorizationUtils.restrictEntity(viewProperties, ViewProperties.class).toString(),
+        expected);
+  }
+}