Skip to content

Commit 1b2271a

Browse files
author
Valentin Thorey
committed
Enfore type check on managed folder in mlflow import
1 parent ce9b441 commit 1b2271a

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

dataikuapi/dss/savedmodel.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
from .ml import DSSTrainedPredictionModelDetails
77
from .managedfolder import DSSManagedFolder
88

9-
from ..utils import _make_zipfile
9+
from ..utils import _make_zipfile, dku_basestring_type
1010

1111
try:
1212
basestring
@@ -166,10 +166,13 @@ def import_mlflow_version_from_managed_folder(self, version_id, managed_folder,
166166
"""
167167
# TODO: Add a check that it's indeed a MLFlow model folder
168168
folder_ref = None
169-
if type(managed_folder) is DSSManagedFolder:
169+
if isinstance(managed_folder, DSSManagedFolder):
170170
folder_ref = "{}.{}".format(managed_folder.project_key, managed_folder.id)
171-
else:
171+
elif isinstance(managed_folder, dku_basestring_type):
172172
folder_ref = managed_folder
173+
else:
174+
raise Exception("managed_folder should either be a string representing the identifier of the managed folder"
175+
" or an instance of dataikuapi.dss.managedfolder.DSSManagedFolder")
173176

174177
self.client._perform_empty(
175178
"POST", "/projects/{project_id}/savedmodels/{saved_model_id}/versions/{version_id}?codeEnvName={codeEnvName}".format(

0 commit comments

Comments
 (0)