Skip to content

Commit 80ee167

Browse files
committed
Support for features_list in the set_core_metadata
1 parent d09b56f commit 80ee167

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

dataikuapi/dss/savedmodel.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -315,6 +315,9 @@ def set_core_metadata(self,
315315
:param list features_list: List of {"name": "feature_name", "type": "feature_type"}
316316
"""
317317

318+
if features_list is not None and get_features_from_dataset is not None:
319+
raise Exception("The information of the features should come either from the features_list or get_features_from_dataset, but not both.")
320+
318321
metadata = self.saved_model.client._perform_json("GET", "/projects/%s/savedmodels/%s/versions/%s/external-ml/metadata" % (self.saved_model.project_key, self.saved_model.sm_id, self.version_id))
319322

320323
if target_column_name is not None:
@@ -330,9 +333,10 @@ def set_core_metadata(self,
330333
#if get_features_from_signature:
331334
# raise Exception("Get features from signature is not yet implemented")
332335

333-
# TODO: Add support for features_list, with validation
336+
if features_list is not None:
337+
metadata["features"] = features_list
334338

335-
self.saved_model.client._perform_empty("PUT",
339+
self.saved_model.client._perform_empty("PUT",
336340
"/projects/%s/savedmodels/%s/versions/%s/external-ml/metadata" % (self.saved_model.project_key, self.saved_model.sm_id, self.version_id),
337341
body=metadata)
338342

0 commit comments

Comments
 (0)