[sc-80908] implementing feedbacks

Author: NawreCode

dataikuapi/dss/admin.py

@@ -403,7 +403,7 @@ def last_successful_login(self):
         """
         Get the last successful login of the user as a :class:`datetime.datetime`
         
-        Returns None if there were no successful login for this user.
+        Returns None if there was no successful login for this user.
 
         :return: the last successful login
         :rtype: :class:`datetime.datetime` or None
@@ -428,7 +428,7 @@ def last_failed_login(self):
     def last_session_activity(self):
         """
         Get the last session activity of the user as a :class:`datetime.datetime`, i.e. the last time
-        he opened a new DSS tab or refreshed his session.
+        the user opened a new DSS tab or refreshed his session.
 
         Returns None if there is no session activity yet.
 

dataikuapi/dssclient.py

@@ -386,7 +386,7 @@ def create_user(self, login, password, display_name='', source_type='LOCAL', gro
     def get_own_user(self):
         return DSSOwnUser(self)
 
-    def list_users_activity(self, as_objects=False, enabledUsersOnly=False):
+    def list_users_activity(self, enabled_users_only=False):
         """
         List all users activity
 
@@ -396,14 +396,11 @@ def list_users_activity(self, as_objects=False, enabledUsersOnly=False):
         :rtype: list of :class:`dataikuapi.dss.admin.DSSUserActivity` or a list of dict
         """
         params = {
-            "enabledUsersOnly": enabledUsersOnly
+            "enabledUsersOnly": enabled_users_only
         }
-        all_activity = self._perform_json("GET", "/admin/users/activity", params=params)
+        all_activity = self._perform_json("GET", "/admin/users-activity", params=params)
 
-        if as_objects:
-            return [DSSUserActivity(self, user_activity["login"], user_activity) for user_activity in all_activity]
-        else:
-            return all_activity
+        return [DSSUserActivity(self, user_activity["login"], user_activity) for user_activity in all_activity]
 
 
     ########################################################