Skip to content

Commit f936cbe

Browse files
committed
Add remarks from PR review
1 parent 0ef90ff commit f936cbe

File tree

1 file changed

+5
-11
lines changed

1 file changed

+5
-11
lines changed

dataikuapi/dss/ml.py

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -473,11 +473,8 @@ def _set_seed(self, seed):
473473

474474
def _set_cv_seed(self, seed):
475475
if seed is not None:
476-
if not isinstance(seed, int):
477-
warnings.warn("HyperparameterSearchSettings ignoring invalid input: seed")
478-
warnings.warn("seed must be an integer")
479-
else:
480-
self._raw_settings["cvSeed"] = seed
476+
assert isinstance(seed, int), "HyperparameterSearchSettings invalid input: cvSeed must be an integer"
477+
self._raw_settings["cvSeed"] = seed
481478

482479
@property
483480
def strategy(self):
@@ -566,8 +563,7 @@ def cv_seed(self, seed):
566563
:param seed: cross-validation seed for splitting the data during hyperparameter search
567564
:type seed: int
568565
"""
569-
assert isinstance(seed, int)
570-
self._raw_settings["cvSeed"] = seed
566+
self._set_cv_seed(seed)
571567

572568
def set_kfold_validation(self, n_folds=5, stratified=True, cv_seed=0):
573569
"""
@@ -595,8 +591,7 @@ def set_kfold_validation(self, n_folds=5, stratified=True, cv_seed=0):
595591
warnings.warn("stratified must be a boolean")
596592
else:
597593
self._raw_settings["stratified"] = stratified
598-
if cv_seed is not None:
599-
self._set_cv_seed(cv_seed)
594+
self._set_cv_seed(cv_seed)
600595

601596
def set_single_split_validation(self, split_ratio=0.8, stratified=True, cv_seed=0):
602597
"""
@@ -624,8 +619,7 @@ def set_single_split_validation(self, split_ratio=0.8, stratified=True, cv_seed=
624619
warnings.warn("stratified must be a boolean")
625620
else:
626621
self._raw_settings["stratified"] = stratified
627-
if cv_seed is not None:
628-
self._set_cv_seed(cv_seed)
622+
self._set_cv_seed(cv_seed)
629623

630624
def set_custom_validation(self, code=None):
631625
"""

0 commit comments

Comments
 (0)