Skip to content

Commit 4e73d28

Browse files
adminfchataigner
authored andcommitted
review comments
1 parent 46203a8 commit 4e73d28

File tree

3 files changed

+3
-1
lines changed

3 files changed

+3
-1
lines changed

.wlock

Whitespace-only changes.

python-clusters/create-gke-cluster/cluster.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464
{
6565
"name": "podIpRange",
6666
"label": "Pod IP range",
67-
"description": "Range name or CIDR block/mask notation, e.g. 10.0.0.0/21 or /21",
67+
"description": "Range name or CIDR block/mask notation, e.g. 10.0.0.0/21 or /21. If using a named range, ensure it is larger than /21.",
6868
"type": "STRING",
6969
"mandatory": false,
7070
"visibilityCondition": "model.isVpcNative"

python-lib/dku_google/clusters.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -211,6 +211,8 @@ def with_labels(self, labels={}):
211211
def with_vpc_native_settings(self, is_vpc_native, pod_ip_range, svc_ip_range):
212212
if is_vpc_native:
213213
self.is_vpc_native = is_vpc_native
214+
if pod_ip_range is not None and len(pod_ip_range) > 0 and pod_ip_range == svc_ip_range:
215+
raise Exception("Service IP range must be different from pod IP range")
214216
self.pod_ip_range = pod_ip_range
215217
self.svc_ip_range = svc_ip_range
216218
return self

0 commit comments

Comments
 (0)