Merge pull request #79 from dataiku/bug/sc-257000-mixed-mode-interpolation-is-inverted

fix: [sc-257000] [pi-system plugin] Mixed mode interpolation is inverted

Author: alexbourret

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## [Version 1.3.1](https://github.com/dataiku/dss-plugin-pi-server/releases/tag/v1.3.1) - Bugfix release - 2025-05-24
+
+- Fix the mix mode interpolation type in Transpose & Synchronise (the Step value was inverted)
+
 ## [Version 1.3.0](https://github.com/dataiku/dss-plugin-pi-server/releases/tag/v1.3.0) - Feature and bug release - 2025-05-23
 
 - Accept timezone in datetime inputs

custom-recipes/pi-system-transpose/recipe.py

@@ -95,7 +95,7 @@ def get_values_at_timestamp(file_handles, seek_timestamp, step_attributes):
             next_timestamps_cache[attribute_index] = attribute_timestamp
             next_values_cache[attribute_index] = attribute_value
             next_cached_timestamp = next_timestamps_cache[attribute_index]
-        if step_attributes.get(attribute_path) is True:
+        if step_attributes.get(attribute_path) is False:
             calculated_value = interpolate(
                 current_timestamps_cache[attribute_index],
                 current_values_cache[attribute_index],
@@ -225,7 +225,11 @@ def get_column_name_specifications():
         is_step_attribute = input_parameters_row.get(step_column_name)
         if is_step_attribute == "True" or is_step_attribute is True:
             step_attributes[attribute_path] = True
+        elif is_step_attribute == "False" or is_step_attribute is False:
+            step_attributes[attribute_path] = False
     elif type_of_interpolation == "interpolation":
+        step_attributes[attribute_path] = False
+    elif type_of_interpolation == "last_value":
         step_attributes[attribute_path] = True
 
 logger.info("Cached all {} attributes".format(file_counter))

plugin.json

@@ -1,6 +1,6 @@
 {
     "id": "pi-system",
-    "version": "1.3.0",
+    "version": "1.3.1",
     "meta": {
         "label": "PI System",
         "description": "Retrieve data from your OSIsoft PI System servers",

python-lib/osisoft_constants.py

@@ -405,7 +405,7 @@ class OSIsoftConstants(object):
         "Security": "{base_url}/eventframes/{webid}/security",
         "SecurityEntries": "{base_url}/eventframes/{webid}/securityentries"
     }
-    PLUGIN_VERSION = "1.3.0"
+    PLUGIN_VERSION = "1.3.1"
     VALUE_COLUMN_SUFFIX = "_val"
     WEB_API_PATH = "piwebapi"
     WRITE_HEADERS = {'X-Requested-With': 'XmlHttpRequest'}