Skip to content

Commit 3f5b237

Browse files
fix: return 0 from delete() when user cancels operation (#1155) (#1316)
When a user answers "no" to "Commit deletes?", the transaction is rolled back but delete() still returned the count of rows that would have been deleted. This was unintuitive - if nothing was deleted, the return value should be 0. Now delete() returns 0 when: - User cancels at the prompt - Nothing to delete (already worked correctly) Fixes #1155 Co-authored-by: Claude Opus 4.5 <[email protected]>
1 parent 38d0f94 commit 3f5b237

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/datajoint/table.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -977,6 +977,7 @@ def cascade(table):
977977
self.connection.cancel_transaction()
978978
if prompt:
979979
logger.warning("Delete cancelled")
980+
delete_count = 0 # Reset count when delete is cancelled
980981
return delete_count
981982

982983
def drop_quick(self):

0 commit comments

Comments
 (0)