optimize progress bar handling in autopopulate

Author: dimitri-yatsenko

datajoint/autopopulate.py

@@ -9,6 +9,7 @@
 from .errors import DataJointError, LostConnectionError
 import signal
 import multiprocessing as mp
+import contextlib
 
 # noinspection PyExceptionInherit,PyCallingNonCallable
 
@@ -236,16 +237,12 @@ def handler(signum, frame):
             with mp.Pool(
                 processes, _initialize_populate, (self, jobs, populate_kwargs)
             ) as pool:
-                if display_progress:
-                    with tqdm(desc="Processes: ", total=nkeys) as pbar:
+                    with (tqdm(desc="Processes: ", total=nkeys) if display_progress else contextlib.nullcontext()) as pbar:
                         for error in pool.imap(_call_populate1, keys, chunksize=1):
                             if error is not None:
                                 error_list.append(error)
-                            pbar.update()
-                else:
-                    for error in pool.imap(_call_populate1, keys):
-                        if error is not None:
-                            error_list.append(error)
+                            if display_progress:
+                                pbar.update()
             self.connection.connect()  # reconnect parent process to MySQL server
 
         # restore original signal handler: