Skip to content

Commit 6c9a0ab

Browse files
committed
Update comments and changelog.
1 parent 59b0227 commit 6c9a0ab

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* Bugfix - Replace use of numpy aliases of built-in types with built-in type. (#938) PR #939
66
* Bugfix - `ExternalTable.delete` should not remove row on error (#953) PR #956
77
* Bugfix - Fix error handling of remove_object function in `s3.py` (#952) PR #955
8-
* Bugfix - Fix sql code generation to comply with sql mode ONLY_FULL_GROUP_BY (#916) PR #965
8+
* Bugfix - Fix sql code generation to comply with sql mode `ONLY_FULL_GROUP_BY` (#916) PR #965
99

1010
### 0.13.2 -- May 7, 2021
1111
* Update `setuptools_certificate` dependency to new name `otumat`

docs-parts/intro/Releases_lang1.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* Bugfix - Replace use of numpy aliases of built-in types with built-in type. (#938) PR #939
55
* Bugfix - `ExternalTable.delete` should not remove row on error (#953) PR #956
66
* Bugfix - Fix error handling of remove_object function in `s3.py` (#952) PR #955
7-
* Bugfix - Fix sql code generation to comply with sql mode ONLY_FULL_GROUP_BY (#916) PR #965
7+
* Bugfix - Fix sql code generation to comply with sql mode ``ONLY_FULL_GROUP_BY`` (#916) PR #965
88

99
0.13.2 -- May 7, 2021
1010
----------------------

tests/test_groupby.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,8 @@
33

44
def test_aggr_with_proj():
55
# issue #944 - only breaks with MariaDB
6+
# Maria db wants all the fields in the select statement to be in the group by
7+
# even if the fields are in fuctional dependency, this is incorrect and MySQL
8+
# implements this properly
9+
# More info on the issue page
610
A.aggr(D.proj(m='id_l'), ..., n='max(m) - min(m)')

0 commit comments

Comments
 (0)