Skip to content

Commit 78f4d0c

Browse files
docs: Add RFC discussion template; fix table header styling
- Add .github/DISCUSSION_TEMPLATE/rfc.yml for enhancement proposals - Fix table header alignment (center instead of right) - Fix excessive padding in table headers by removing p tag margins Co-Authored-By: Claude Opus 4.5 <[email protected]>
1 parent 587ee69 commit 78f4d0c

File tree

2 files changed

+113
-3
lines changed

2 files changed

+113
-3
lines changed
Lines changed: 107 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
1+
title: "[RFC] "
2+
labels:
3+
- rfc
4+
- "status: proposed"
5+
body:
6+
- type: markdown
7+
attributes:
8+
value: |
9+
## DataJoint Enhancement Proposal
10+
11+
Use this template to propose changes to DataJoint specifications, APIs, or documentation structure.
12+
13+
**Before submitting:**
14+
- Search existing discussions to avoid duplicates
15+
- Consider starting with an informal discussion in the Ideas category first
16+
17+
- type: textarea
18+
id: summary
19+
attributes:
20+
label: Summary
21+
description: A brief, one-paragraph explanation of the proposal.
22+
placeholder: This proposal adds/changes/removes...
23+
validations:
24+
required: true
25+
26+
- type: textarea
27+
id: motivation
28+
attributes:
29+
label: Motivation
30+
description: |
31+
Why is this change needed? What problem does it solve?
32+
Include concrete use cases and examples where possible.
33+
placeholder: |
34+
Currently, users need to...
35+
This causes problems when...
36+
With this change, users could...
37+
validations:
38+
required: true
39+
40+
- type: textarea
41+
id: design
42+
attributes:
43+
label: Proposed Design
44+
description: |
45+
Detailed explanation of the proposed solution.
46+
Include code examples, API signatures, or schema definitions as appropriate.
47+
placeholder: |
48+
## API Changes
49+
```python
50+
# Example usage
51+
```
52+
53+
## Behavior
54+
- When X happens, Y should occur
55+
- Error handling: ...
56+
validations:
57+
required: true
58+
59+
- type: textarea
60+
id: alternatives
61+
attributes:
62+
label: Alternatives Considered
63+
description: What other approaches were considered and why were they not chosen?
64+
placeholder: |
65+
1. Alternative A: ...
66+
Rejected because: ...
67+
68+
2. Alternative B: ...
69+
Rejected because: ...
70+
71+
- type: textarea
72+
id: compatibility
73+
attributes:
74+
label: Backwards Compatibility
75+
description: |
76+
How does this affect existing users?
77+
- Breaking changes?
78+
- Migration path?
79+
- Deprecation timeline?
80+
placeholder: |
81+
This change is/is not backwards compatible.
82+
83+
Migration path:
84+
1. ...
85+
86+
- type: textarea
87+
id: implementation
88+
attributes:
89+
label: Implementation Notes
90+
description: |
91+
Optional: Technical details, affected files, estimated scope.
92+
Prototyping in parallel with RFC discussion is encouraged.
93+
placeholder: |
94+
Affected components:
95+
- datajoint-python/src/datajoint/...
96+
97+
Estimated scope: small/medium/large
98+
99+
- type: checkboxes
100+
id: checklist
101+
attributes:
102+
label: Checklist
103+
options:
104+
- label: I have searched existing discussions and issues for duplicates
105+
required: true
106+
- label: I have considered backwards compatibility
107+
required: true

src/datajoint/preview.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,10 @@ def get_html_display_value(tup, name, idx):
122122
}
123123
.Table th{
124124
background: #A0A0A0; color: #ffffff; padding:2px 4px; border:#f0e0e0 1px solid;
125-
font-weight: normal; font-family: monospace; font-size: 75%;
125+
font-weight: normal; font-family: monospace; font-size: 75%; text-align: center;
126+
}
127+
.Table th p{
128+
margin: 0;
126129
}
127130
.Table td{
128131
padding:2px 4px; border:#f0e0e0 1px solid; font-size: 75%;
@@ -168,7 +171,7 @@ def get_html_display_value(tup, name, idx):
168171
/* Dark mode support */
169172
@media (prefers-color-scheme: dark) {
170173
.Table th{
171-
background: #4a4a4a; color: #ffffff; border:#555555 1px solid;
174+
background: #4a4a4a; color: #ffffff; border:#555555 1px solid; text-align: center;
172175
}
173176
.Table td{
174177
border:#555555 1px solid;
@@ -203,7 +206,7 @@ def get_html_display_value(tup, name, idx):
203206
{title}
204207
<div style="max-height:1000px;max-width:1500px;overflow:auto;">
205208
<table border="1" class="Table">
206-
<thead> <tr style="text-align: right;"> <th> {head} </th> </tr> </thead>
209+
<thead> <tr> <th> {head} </th> </tr> </thead>
207210
<tbody> <tr> {body} </tr> </tbody>
208211
</table>
209212
{ellipsis}

0 commit comments

Comments
 (0)