Skip to content

Commit 8035628

Browse files
authored
Merge pull request #1144 from ethho/fix-dev-container
PLAT-142: Fix dev container follow-up
2 parents 90d1b5d + 43598c9 commit 8035628

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

.devcontainer/devcontainer.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
"onCreateCommand": "python3 -m pip install -e .",
3232
"features": {
3333
"ghcr.io/devcontainers/features/git:1": {},
34+
"ghcr.io/devcontainers/features/docker-in-docker:2": {},
3435
},
3536
// Configure tool-specific properties.
3637
"customizations": {

.devcontainer/docker-compose.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,13 @@ services:
66
# folder. Note that the path of the Dockerfile and context is relative to the *primary*
77
# docker-compose.yml file (the first in the devcontainer.json "dockerComposeFile"
88
# array). The sample below assumes your primary file is in the root of your project.
9-
container_name: devcontainer
10-
image: devcontainer
9+
container_name: datajoint-python-devcontainer
10+
image: datajoint/datajoint-python-devcontainer:${PY_VER:-3.11}-${DISTRO:-buster}
1111
build:
1212
context: .
1313
dockerfile: .devcontainer/Dockerfile
1414
args:
15-
- PY_VER=${PY_VER:-3.8}
15+
- PY_VER=${PY_VER:-3.11}
1616
- DISTRO=${DISTRO:-buster}
1717

1818
volumes:

0 commit comments

Comments
 (0)