fix: Address review comments on types and storage

- Remove unused RowList and PrimaryKeyList type aliases
- Change list to list[Any] in Restriction type
- Use TYPE_CHECKING instead of 'if False:' for conditional import
- Remove redundant isinstance check in is_remote_url (type annotation guarantees str)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

Author: dimitri-yatsenko

src/datajoint/storage.py

@@ -42,8 +42,6 @@ def is_remote_url(path: str) -> bool:
     bool
         True if path starts with a supported remote protocol.
     """
-    if not isinstance(path, str):
-        return False
     return path.lower().startswith(REMOTE_PROTOCOLS)
 
 

src/datajoint/types.py

@@ -9,22 +9,16 @@
 
 from __future__ import annotations
 
-from typing import Any, TypeAlias
+from typing import TYPE_CHECKING, Any, TypeAlias
 
 # Primary key types
 PrimaryKey: TypeAlias = dict[str, Any]
 """A dictionary mapping attribute names to values that uniquely identify an entity."""
 
-PrimaryKeyList: TypeAlias = list[dict[str, Any]]
-"""A list of primary key dictionaries."""
-
 # Row/record types
 Row: TypeAlias = dict[str, Any]
 """A single row/record as a dictionary mapping attribute names to values."""
 
-RowList: TypeAlias = list[dict[str, Any]]
-"""A list of rows/records."""
-
 # Attribute types
 AttributeName: TypeAlias = str
 """Name of a table attribute/column."""
@@ -47,7 +41,7 @@
 """Mapping of child_attr -> (parent_table, parent_attr) for foreign keys."""
 
 # Restriction types
-Restriction: TypeAlias = str | dict[str, Any] | bool | "QueryExpression" | list | None
+Restriction: TypeAlias = str | dict[str, Any] | bool | "QueryExpression" | list[Any] | None
 """Valid restriction types for query operations."""
 
 # Fetch result types
@@ -56,5 +50,5 @@
 
 
 # For avoiding circular imports
-if False:  # TYPE_CHECKING equivalent that's always False
+if TYPE_CHECKING:
     from .expression import QueryExpression