update test.

Author: jverswijver

datajoint/external.py

@@ -1,6 +1,7 @@
 from pathlib import Path, PurePosixPath, PureWindowsPath
 from collections.abc import Mapping
 from tqdm import tqdm
+import logging
 from .settings import config
 from .errors import DataJointError, MissingExternalFile
 from .hash import uuid_from_buffer, uuid_from_file
@@ -10,6 +11,8 @@
 from . import s3
 from .utils import safe_write, safe_copy
 
+logger = logging.getLogger(__name__.split(".")[0])
+
 CACHE_SUBFOLDING = (
     2,
     2,
@@ -326,7 +329,9 @@ def _need_checksum(local_filepath):
                             f"'{local_filepath}' downloaded but did not pass checksum'"
                         )
             if not _need_checksum(local_filepath):
-                print(f"WARNING SKIPPED CHECKSUM FOR FILE WITH HASH: {contents_hash}")
+                logger.warning(
+                    f"WARNING SKIPPED CHECKSUM FOR FILE WITH HASH: {contents_hash}"
+                )
                 # This will turn into a proper logger when we implement the datajoint logger
             return str(local_filepath), contents_hash
 

tests/test_filepath.py

@@ -4,6 +4,10 @@
 from pathlib import Path
 import random
 from .schema_external import schema, Filepath, FilepathS3, stores_config
+import logging
+import io
+
+logger = logging.getLogger("datajoint")
 
 
 def setUp(self):
@@ -188,7 +192,21 @@ def test_filepath_class_s3_again():
 
 
 def test_filepath_class_no_checksum():
+    log_capture = io.StringIO()
+    stream_handler = logging.StreamHandler(log_capture)
+    log_format = logging.Formatter(
+        "[%(asctime)s][%(funcName)s][%(levelname)s]: %(message)s"
+    )
+    stream_handler.setFormatter(log_format)
+    stream_handler.set_name("test_limit_warning")
+    logger.addHandler(stream_handler)
     test_filepath_class(verify_checksum=False)
+    log_contents = log_capture.getvalue()
+    log_capture.close()
+    for handler in logger.handlers:  # Clean up handler
+        if handler.name == "test_limit_warning":
+            logger.removeHandler(handler)
+    assert "WARNING SKIPPED CHECKSUM FOR FILE WITH HASH" in log_contents
 
 
 def test_filepath_cleanup(table=Filepath(), store="repo"):