feat: remove logging of success jobs in Jobs table

Author: ttngu207

datajoint/autopopulate.py

@@ -600,15 +600,6 @@ def purge_jobs(self):
         """
         invalid_removed = 0
 
-        success_query = self.jobs & {"table_name": self.target.table_name} & "status = 'success'"
-        if success_query:
-            invalid_success = len(success_query) - len(self.target)
-            if invalid_success > 0:
-                for key, job_key in zip(*success_query.fetch("KEY", "key")):
-                    if not (self.target & job_key):
-                        (self.jobs & key).delete()
-                        invalid_removed += 1
-
         incomplete_query = self.jobs & {"table_name": self.target.table_name} & "status != 'success'"
         if incomplete_query:
             keys2do = self._jobs_to_do({}).fetch("KEY")

datajoint/jobs.py

@@ -185,40 +185,16 @@ def ignore(self, table_name, key, message=""):
 
         return True
 
-    def complete(self, table_name, key, run_duration=None, run_metadata=None):
+    def complete(self, table_name, key):
         """
         Log a completed job.  When a job is completed, its reservation entry is deleted.
 
         Args:
             table_name: `database`.`table_name`
             key: the dict of the job's primary key
-            run_duration: duration in second of the job run
-            run_metadata: dict containing metadata about the run (e.g. code version, environment info)
         """
         job_key = dict(table_name=table_name, key_hash=key_hash(key))
-        if self & job_key:
-            current_status = (self & job_key).fetch1("status")
-            if current_status == "success":
-                return
-
-        with config(enable_python_native_blobs=True):
-            self.insert1(
-                dict(
-                    table_name=table_name,
-                    key_hash=key_hash(key),
-                    status="success",
-                    host=platform.node(),
-                    pid=os.getpid(),
-                    connection_id=self.connection.connection_id,
-                    user=self._user,
-                    key=_jsonify(key),
-                    run_duration=run_duration,
-                    run_metadata=_jsonify(run_metadata) if run_metadata else None,
-                    timestamp=datetime.datetime.utcnow(),
-                ),
-                replace=True,
-                ignore_extra_fields=True,
-            )
+        (self & job_key).delete()
 
     def error(self, table_name, key, error_message, error_stack=None, run_duration=None, run_metadata=None):
         """