File tree Expand file tree Collapse file tree 4 files changed +5
-8
lines changed Expand file tree Collapse file tree 4 files changed +5
-8
lines changed Original file line number Diff line number Diff line change 6
6
* Bugfix - Replace use of numpy aliases of built-in types with built-in type. (#938 ) PR #939
7
7
* Bugfix - ` ExternalTable.delete ` should not remove row on error (#953 ) PR #956
8
8
* Bugfix - Fix error handling of remove_object function in ` s3.py ` (#952 ) PR #955
9
- * Bugfix - Fix regression issue with DISTINCT clause and GROUP_BY (#914 ) PR #963
9
+ * Bugfix - Fix regression issue with ` DISTINCT ` clause and ` GROUP_BY ` (#914 ) PR #963
10
10
* Bugfix - Fix assertion error when performing a union into a join (#930 ) PR #967
11
11
12
12
### 0.13.2 -- May 7, 2021
Original file line number Diff line number Diff line change @@ -104,7 +104,7 @@ def where_clause(self):
104
104
return '' if not self .restriction else ' WHERE(%s)' % ')AND(' .join (
105
105
str (s ) for s in self .restriction )
106
106
107
- def make_sql (self , fields = None , distinct = True ):
107
+ def make_sql (self , fields = None ):
108
108
"""
109
109
Make the SQL SELECT statement.
110
110
:param fields: used to explicitly set the select attributes
Original file line number Diff line number Diff line change 5
5
* Bugfix - Replace use of numpy aliases of built-in types with built-in type. (#938) PR #939
6
6
* Bugfix - `ExternalTable.delete ` should not remove row on error (#953) PR #956
7
7
* Bugfix - Fix error handling of remove_object function in `s3.py ` (#952) PR #955
8
- * Bugfix - Fix regression issue with DISTINCT clause and GROUP_BY (#914) PR #963
9
8
* Bugfix - Fix assertion error when performing a union into a join (#930) PR #967
9
+ * Bugfix - Fix regression issue with ``DISTINCT `` and ``GROUP_BY `` clause (#914) PR #963
10
10
11
11
0.13.2 -- May 7, 2021
12
12
----------------------
Original file line number Diff line number Diff line change @@ -292,12 +292,9 @@ def test_query_caching(self):
292
292
def test_fetch_group_by (self ):
293
293
# https://github.com/datajoint/datajoint-python/issues/914
294
294
295
- expected_data = [{'parent_id' : 1 }]
296
- fetched_data = Parent ().fetch ('KEY' , order_by = 'name' )
297
- print (fetched_data )
298
- assert fetched_data == expected_data
295
+ assert Parent ().fetch ('KEY' , order_by = 'name' ) == [{'parent_id' : 1 }]
299
296
300
- def test_dj_U_DISTINCT (self ):
297
+ def test_dj_u_distinct (self ):
301
298
# Test developed to see if removing DISTINCT from the select statement
302
299
# generation breakes the dj.U universal set imlementation
303
300
You can’t perform that action at this time.
0 commit comments