Skip to content

Commit e905dce

Browse files
Merge pull request #985 from ttngu207/master
bugfix in `unite_master_parts` - handles dj.Lookup tables
2 parents bf74266 + 1646fde commit e905dce

File tree

4 files changed

+7
-1
lines changed

4 files changed

+7
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
## Release notes
22

33
### 0.13.3 -- TBD
4+
* Bugfix - Fix error in listing ancestors, descendants with part tables.
45
* Bugfix - Fix Python 3.10 compatibility (#983) PR #972
56
* Bugfix - Allow renaming non-conforming attributes in proj (#982) PR #972
67
* Add - Expose proxy feature for S3 external stores (#961) PR #962

datajoint/dependencies.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ def unite_master_parts(lst):
1818
"""
1919
for i in range(2, len(lst)):
2020
name = lst[i]
21-
match = re.match(r'(?P<master>`\w+`.`\w+)__\w+`', name)
21+
match = re.match(r'(?P<master>`\w+`.`#?\w+)__\w+`', name)
2222
if match: # name is a part table
2323
master = match.group('master')
2424
for j in range(i-1, -1, -1):

docs-parts/intro/Releases_lang1.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
0.13.3 -- TBD
22
----------------------
3+
* Bugfix - Fix error in listing ancestors, descendants with part tables.
34
* Bugfix - Fix Python 3.10 compatibility (#983) PR #972
45
* Bugfix - Allow renaming non-conforming attributes in proj (#982) PR #972
56
* Add - Expose proxy feature for S3 external stores (#961) PR #962

tests/test_dependencies.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,17 @@ def test_unite_master_parts():
99
['`s`.`a`', '`s`.`a__q`', '`s`.`a__r`', '`s`.`b`', '`s`.`b__q`', '`s`.`c`', '`s`.`c__q`', '`s`.`d`'])
1010
assert_list_equal(unite_master_parts(
1111
[
12+
'`lab`.`#equipment`',
1213
'`cells`.`cell_analysis_method`',
1314
'`cells`.`cell_analysis_method_task_type`',
1415
'`cells`.`cell_analysis_method_users`',
1516
'`cells`.`favorite_selection`',
1617
'`cells`.`cell_analysis_method__cell_selection_params`',
18+
'`lab`.`#equipment__config`',
1719
'`cells`.`cell_analysis_method__field_detect_params`']),
1820
[
21+
'`lab`.`#equipment`',
22+
'`lab`.`#equipment__config`',
1923
'`cells`.`cell_analysis_method`',
2024
'`cells`.`cell_analysis_method__cell_selection_params`',
2125
'`cells`.`cell_analysis_method__field_detect_params`',

0 commit comments

Comments
 (0)