Skip to content

Commit f2eaf89

Browse files
minor syntax
1 parent d1a9147 commit f2eaf89

File tree

1 file changed

+17
-20
lines changed

1 file changed

+17
-20
lines changed

tests/test_jobs.py

Lines changed: 17 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -17,37 +17,35 @@ def test_reserve_job():
1717
table_name = 'fake_table'
1818
# reserve jobs
1919
for key in subjects.fetch('KEY'):
20-
assert_true(schema.schema.jobs.reserve(table_name, key),
21-
'failed to reserve a job')
20+
assert_true(schema.schema.jobs.reserve(table_name, key), 'failed to reserve a job')
21+
2222
# refuse jobs
2323
for key in subjects.fetch('KEY'):
24-
assert_false(schema.schema.jobs.reserve(table_name, key),
25-
'failed to respect reservation')
24+
assert_false(schema.schema.jobs.reserve(table_name, key), 'failed to respect reservation')
25+
2626
# complete jobs
2727
for key in subjects.fetch('KEY'):
2828
schema.schema.jobs.complete(table_name, key)
29-
assert_false(schema.schema.jobs,
30-
'failed to free jobs')
29+
assert_false(schema.schema.jobs, 'failed to free jobs')
30+
3131
# reserve jobs again
3232
for key in subjects.fetch('KEY'):
33-
assert_true(schema.schema.jobs.reserve(table_name, key),
34-
'failed to reserve new jobs')
33+
assert_true(schema.schema.jobs.reserve(table_name, key), 'failed to reserve new jobs')
34+
3535
# finish with error
3636
for key in subjects.fetch('KEY'):
37-
schema.schema.jobs.error(table_name, key,
38-
"error message")
37+
schema.schema.jobs.error(table_name, key, "error message")
38+
3939
# refuse jobs with errors
4040
for key in subjects.fetch('KEY'):
41-
assert_false(schema.schema.jobs.reserve(table_name, key),
42-
'failed to ignore error jobs')
41+
assert_false(schema.schema.jobs.reserve(table_name, key), 'failed to ignore error jobs')
42+
4343
# clear error jobs
4444
(schema.schema.jobs & dict(status="error")).delete()
45-
assert_false(schema.schema.jobs,
46-
'failed to clear error jobs')
45+
assert_false(schema.schema.jobs, 'failed to clear error jobs')
4746

4847

4948
def test_restrictions():
50-
# clear out jobs table
5149
jobs = schema.schema.jobs
5250
jobs.delete()
5351
jobs.reserve('a', {'key': 'a1'})
@@ -56,10 +54,9 @@ def test_restrictions():
5654
jobs.error('a', {'key': 'a2'}, 'error')
5755
jobs.error('b', {'key': 'b1'}, 'error')
5856

59-
assert_true(len(jobs & 'table_name = "a"') == 2, 'There should be two entries for table a')
60-
assert_true(len(jobs & 'status = "error"') == 2, 'There should be two entries with error status')
61-
assert_true(len(jobs & 'table_name = "a"' & 'status = "error"') == 1,
62-
'There should be only one entries with error status in table a')
57+
assert_true(len(jobs & {'table_name': "a"}) == 2)
58+
assert_true(len(jobs & {'status': "error"}) == 2)
59+
assert_true(len(jobs & {'table_name': "a", 'status': "error"}) == 1)
6360
jobs.delete()
6461

6562

@@ -109,7 +106,7 @@ def test_long_error_message():
109106
assert_true(subjects)
110107
table_name = 'fake_table'
111108

112-
key = list(subjects.fetch('KEY'))[0]
109+
key = subjects.fetch('KEY')[0]
113110

114111
# test long error message
115112
schema.schema.jobs.reserve(table_name, key)

0 commit comments

Comments
 (0)