Allow EMAIL_DOMAIN_ALLOW_LIST to be null and retain email auth feature

ml-evs · ml-evs · commit e85b236f7ddc · 2025-12-03T00:44:17.000Z
diff --git a/pydatalab/src/pydatalab/feature_flags.py b/pydatalab/src/pydatalab/feature_flags.py
@@ -79,11 +79,13 @@ def check_feature_flags(app):
             )
             FEATURE_FLAGS.email_notifications = False
 
-        if CONFIG.EMAIL_DOMAIN_ALLOW_LIST and FEATURE_FLAGS.email_notifications:
+        if (
+            CONFIG.EMAIL_DOMAIN_ALLOW_LIST is None or CONFIG.EMAIL_DOMAIN_ALLOW_LIST
+        ) and FEATURE_FLAGS.email_notifications:
             FEATURE_FLAGS.auth_mechanisms.email = True
         else:
             LOGGER.warning(
-                "`CONFIG.EMAIL_DOMAIN_ALLOW_LIST` is usnet or empty; email registration will not be enabled."
+                "`CONFIG.EMAIL_DOMAIN_ALLOW_LIST` is unset or empty; email registration will not be enabled."
             )
 
     if CONFIG.IDENTIFIER_PREFIX == "test":

Original file line number	Diff line number	Diff line change
`@@ -79,11 +79,13 @@ def check_feature_flags(app):`
`79`	`79`	`)`
`80`	`80`	`FEATURE_FLAGS.email_notifications = False`
`81`	`81`
`82`		`- if CONFIG.EMAIL_DOMAIN_ALLOW_LIST and FEATURE_FLAGS.email_notifications:`
	`82`	`+ if (`
	`83`	`+ CONFIG.EMAIL_DOMAIN_ALLOW_LIST is None or CONFIG.EMAIL_DOMAIN_ALLOW_LIST`
	`84`	`+ ) and FEATURE_FLAGS.email_notifications:`
`83`	`85`	`FEATURE_FLAGS.auth_mechanisms.email = True`
`84`	`86`	`else:`
`85`	`87`	`LOGGER.warning(`
`86`		- "`CONFIG.EMAIL_DOMAIN_ALLOW_LIST` is usnet or empty; email registration will not be enabled."
	`88`	+ "`CONFIG.EMAIL_DOMAIN_ALLOW_LIST` is unset or empty; email registration will not be enabled."
`87`	`89`	`)`
`88`	`90`
`89`	`91`	`if CONFIG.IDENTIFIER_PREFIX == "test":`