Skip to content

Commit d89a2da

Browse files
authored
JupyteLab Theme + Remove Storybook from jupyter-react package (#352)
* docs: yarn * fix: lint * theme * storybook: rm from react * lint * example: theme * fix: theme * fix: css
1 parent 184e821 commit d89a2da

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+390
-2236
lines changed

docs/docs/develop/dev-environment/index.mdx

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,27 @@
44

55
🚨 Only Yarn v3 is supported - npm, pnpm, yarn v1... will not work, this is due to JupyterLab requirements.
66

7+
Create a `.yarnrc.yml` file in the root of your project to use `node_modules`.
8+
9+
```yaml
10+
enableImmutableInstalls: false
11+
enableInlineBuilds: false
12+
enableTelemetry: false
13+
httpTimeout: 60000
14+
nodeLinker: node-modules
15+
npmRegistryServer: "https://registry.yarnpkg.com"
16+
17+
# This will fix the build error with @lerna/legacy-package-management
18+
# See https://github.com/lerna/repro/pull/11
19+
packageExtensions:
20+
"@lerna/legacy-package-management@*":
21+
dependencies:
22+
"@lerna/child-process": "*"
23+
"js-yaml": "*"
24+
"rimraf": "*"
25+
peerDependencies:
26+
"nx": "*"
27+
```
728
:::
829
930
Choose the way you want to develop Jupyter UI:

packages/react/.storybook/custom.css

Lines changed: 0 additions & 11 deletions
This file was deleted.

packages/react/.storybook/main.ts

Lines changed: 0 additions & 139 deletions
This file was deleted.

packages/react/.storybook/manager.ts

Lines changed: 0 additions & 12 deletions
This file was deleted.

packages/react/.storybook/preview-head.html

Lines changed: 0 additions & 31 deletions
This file was deleted.

packages/react/.storybook/preview.tsx

Lines changed: 0 additions & 70 deletions
This file was deleted.

packages/react/.storybook/theme.ts

Lines changed: 0 additions & 13 deletions
This file was deleted.

packages/react/package.json

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@datalayer/jupyter-react",
3-
"version": "0.19.3",
3+
"version": "0.19.7",
44
"description": "Jupyter React - React.js components 100% compatible with Jupyter.",
55
"license": "MIT",
66
"main": "lib/index.js",
@@ -59,10 +59,7 @@
5959
"typedoc": "typedoc ./src",
6060
"watch": "run-p watch:src watch:labextension",
6161
"watch:labextension": "jupyter labextension watch .",
62-
"watch:src": "tsc -w",
63-
"storybook": "storybook dev -p 6006",
64-
"storybook:ci": "storybook dev -p 6006 --ci --quiet",
65-
"build:storybook": "storybook build"
62+
"watch:src": "tsc -w"
6663
},
6764
"dependencies": {
6865
"@codemirror/lang-python": "^6.0.1",
@@ -170,16 +167,6 @@
170167
"@mermaid-js/mermaid-zenuml": "0.2.0",
171168
"@playwright/test": "^1.40.1",
172169
"@primer/octicons-react": "^19.8.0",
173-
"@storybook/addon-essentials": "^8.0.10",
174-
"@storybook/addon-interactions": "^8.0.10",
175-
"@storybook/addon-links": "^8.0.10",
176-
"@storybook/addon-onboarding": "^8.0.10",
177-
"@storybook/addon-themes": "^8.0.10",
178-
"@storybook/blocks": "^8.0.10",
179-
"@storybook/manager-api": "^8.0.10",
180-
"@storybook/react": "^8.0.10",
181-
"@storybook/react-webpack5": "^8.0.10",
182-
"@storybook/test": "^8.0.10",
183170
"@types/codemirror": "^5.60.4",
184171
"@types/jest": "^29.4.0",
185172
"@types/marked": "^4.0.1",
@@ -218,7 +205,6 @@
218205
"process": "^0.11.10",
219206
"rimraf": "^3.0.2",
220207
"source-map-loader": "^5.0.0",
221-
"storybook": "^8.0.10",
222208
"stream": "^0.0.2",
223209
"stream-browserify": "^2.0.2",
224210
"style-loader": "^2.0.0",
@@ -295,7 +281,6 @@
295281
"**/*.d.ts",
296282
"tests",
297283
"**/__tests__",
298-
"stories",
299284
"playwright.config.ts"
300285
],
301286
"eslintConfig": {

packages/react/src/components/notebook/Notebook.tsx

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -501,13 +501,11 @@ export const Notebook = (props: INotebookProps) => {
501501
);
502502
})}
503503
</Box>
504-
{/* {isLoading ? (
504+
{isLoading ?
505505
<Loader />
506-
) : (
506+
:
507507
<Box>{adapter && <Lumino id={id}>{adapter.panel}</Lumino>}</Box>
508-
)} */}
509-
<Loader />
510-
<Box>{adapter && <Lumino id={id}>{adapter.panel}</Lumino>}</Box>
508+
}
511509
</Box>
512510
</Box>
513511
);

0 commit comments

Comments
 (0)