Skip to content

Commit afcf637

Browse files
committed
improve tests
1 parent 9e88781 commit afcf637

File tree

1 file changed

+2
-24
lines changed
  • lib/dl_auth_native/dl_auth_native_tests/unit/middleware

1 file changed

+2
-24
lines changed

lib/dl_auth_native/dl_auth_native_tests/unit/middleware/test_flask.py

Lines changed: 2 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -156,31 +156,10 @@ def test_service_auth_missing_token(
156156

157157

158158
def test_service_auth_not_configured(
159-
token_decoder: dl_auth_native.DecoderProtocol,
159+
flask_app: flask.Flask,
160160
) -> None:
161161
"""When master_token is None, service endpoints should return 401."""
162-
app = flask.Flask(__name__)
163-
164-
dl_api_commons_flask_middlewares.ContextVarMiddleware().wrap_flask_app(app)
165-
dl_api_commons_flask_middlewares.RequestLoggingContextControllerMiddleWare().set_up(app)
166-
dl_api_commons_flask_middlewares.RequestIDService(
167-
append_local_req_id=False,
168-
request_id_app_prefix=None,
169-
).set_up(app)
170-
dl_auth_native.FlaskMiddleware(
171-
token_decoder=token_decoder,
172-
).set_up(app)
173-
ReqCtxInfoMiddleware().set_up(app)
174-
175-
class ServiceView(MethodView):
176-
REQUIRED_RESOURCES = frozenset({RequiredResourceCommon.ONLY_SERVICES_ALLOWED})
177-
178-
def get(self) -> flask.Response:
179-
return flask.jsonify({"ok": True})
180-
181-
app.add_url_rule("/service", view_func=ServiceView.as_view("service"))
182-
183-
with app.test_client() as client:
162+
with flask_app.test_client() as client:
184163
response = client.get(
185164
"/service",
186165
headers={DLHeadersCommon.US_MASTER_TOKEN.value: "some-token"},
@@ -191,7 +170,6 @@ def get(self) -> flask.Response:
191170

192171
def test_user_endpoint_still_uses_jwt(
193172
flask_app_with_service_auth: flask.Flask,
194-
token_decoder: mock.Mock,
195173
) -> None:
196174
"""Regular endpoints should still require JWT auth, not accept master token."""
197175
with flask_app_with_service_auth.test_client() as client:

0 commit comments

Comments
 (0)