typed Dataset component and dataset actions

Author: dvortsovs

src/shared/schema/bi/types/datasets.ts

@@ -200,20 +200,20 @@ export type GetDataSetFieldsByIdArgs = WorkbookIdArg & {
 };
 
 type CreateDatasetBaseArgs = {
-    dataset: Dataset['dataset'];
+    dataset: Partial<Dataset['dataset']>;
     name: string;
     created_via?: string;
 };
 
-type CreateDirDatasetArgs = CreateDatasetBaseArgs & {
+export type CreateDirDatasetArgs = CreateDatasetBaseArgs & {
     dir_path: string;
 };
 
-type CreateWorkbookDatsetArgs = CreateDatasetBaseArgs & {
+export type CreateWorkbookDatasetArgs = CreateDatasetBaseArgs & {
     workbook_id: string;
 };
 
-export type CreateDatasetArgs = CreateDirDatasetArgs | CreateWorkbookDatsetArgs;
+export type CreateDatasetArgs = CreateDirDatasetArgs | CreateWorkbookDatasetArgs;
 
 export type CreateDatasetResponse = Id & DatasetWithOptions;
 
@@ -222,7 +222,7 @@ export type UpdateDatasetResponse = DatasetWithOptions;
 export type UpdateDatasetArgs = {
     version: DatasetVersion;
     data: {
-        dataset: Dataset['dataset'];
+        dataset: Partial<Dataset['dataset']>;
     };
 } & DatasetId;
 

src/shared/types/dataset.ts

@@ -265,7 +265,7 @@ export interface DatasetOptions {
         }[];
         max: number;
     };
-    source_listing: {
+    source_listing?: {
         supports_source_search: boolean;
         supports_source_pagination: boolean;
         supports_db_name_listing: boolean;

src/ui/store/actions/editHistory.ts

@@ -69,7 +69,9 @@ interface ResetEditHistoryUnitAction {
     unitId: string;
 }
 
-export function resetEditHistoryUnit({unitId}: Omit<ResetEditHistoryUnitAction, 'type'>) {
+export function resetEditHistoryUnit({
+    unitId,
+}: Omit<ResetEditHistoryUnitAction, 'type'>): ResetEditHistoryUnitAction {
     return {
         type: RESET_EDIT_HISTORY_UNIT,
         unitId,

src/ui/units/datasets/components/DatasetPanel/DatasetPanel.tsx

@@ -38,7 +38,7 @@ function TabSwitch(props: TabSwitchProps) {
         <RadioButton
             qa={DatasetPanelQA.TabRadio}
             value={tab}
-            onChange={(e) => switchTab(e.target.value)}
+            onChange={(e) => switchTab(e.target.value as DatasetTab)}
         >
             {tabs.map(({value, label, disabled}) => (
                 <RadioButton.Option
@@ -57,7 +57,7 @@ type DatasetPanelProps = StateProps & {
     isCreationProcess: boolean;
     previewEnabled: boolean;
     tab: DatasetTab;
-    switchTab: (tab: string) => void;
+    switchTab: (tab: DatasetTab) => void;
     refreshSources: () => void;
     openDialogFieldEditor: () => void;
     togglePreview: () => void;

src/ui/units/datasets/components/DialogCreateDataset/DialogCreateDataset.tsx

@@ -1,7 +1,6 @@
 import React from 'react';
 
 import {I18n} from '../../../../../i18n';
-import type {CreateDatasetResponse} from '../../../../../shared/schema/types';
 import type {
     DialogCreateWorkbookEntryProps,
     EntryDialogBaseProps,
@@ -17,18 +16,19 @@ type DialogCreateDatasetBaseProps = {
     visible: boolean;
 };
 
-type DialogCreateDatasetInNavigationProps = {
-    onApply: EntryDialogBaseProps<CreateDatasetResponse>['onApply'];
+export type DialogCreateDatasetInNavigationProps = {
+    onApply: EntryDialogBaseProps<void>['onApply'];
     creationScope: 'navigation';
 };
 
-type DialogCreateDatasetInWorkbookProps = {
-    onApply: DialogCreateWorkbookEntryProps<CreateDatasetResponse>['onApply'];
+export type DialogCreateDatasetInWorkbookProps = {
+    onApply: DialogCreateWorkbookEntryProps<void>['onApply'];
     creationScope: 'workbook';
 };
 
-type DialogCreateDatasetProps = DialogCreateDatasetBaseProps &
-    (DialogCreateDatasetInNavigationProps | DialogCreateDatasetInWorkbookProps);
+type DialogCreateDatasetProps =
+    | (DialogCreateDatasetBaseProps & DialogCreateDatasetInNavigationProps)
+    | (DialogCreateDatasetBaseProps & DialogCreateDatasetInWorkbookProps);
 
 const DialogCreateDataset = (props: DialogCreateDatasetProps) => {
     const {visible, onClose} = props;