Merge pull request #358 from nblumhardt/tidy-health-output

Only include detailed HTTP diagnostics in `node health` output when `--verbose` is set

Author: nblumhardt

src/SeqCli/Cli/Commands/Node/HealthCommand.cs

@@ -54,13 +54,16 @@ protected override async Task<int> Run()
         try
         {
             var response = await connection.Client.HttpClient.GetAsync("health");
-            Console.WriteLine($"HTTP {response.Version} {((int)response.StatusCode).ToString(CultureInfo.InvariantCulture)} {response.ReasonPhrase}");
+            Log.Information("HTTP {HttpVersion} {StatusCode} {ReasonPhrase}", response.Version, (int)response.StatusCode, response.ReasonPhrase);
+            
             foreach (var (key, values) in response.Headers.Concat(response.Content.Headers))
             foreach (var value in values)
             {
-                Console.WriteLine($"{key}: {value}");
+                Log.Information("{HeaderName}: {HeaderValue}", key, value);
             }
+            
             Console.WriteLine(await response.Content.ReadAsStringAsync());
+            
             return response.IsSuccessStatusCode ? 0 : 1;
         }
         catch (Exception ex)

test/SeqCli.EndToEnd/Node/NodeDemoteTestCase.cs

@@ -6,7 +6,7 @@
 
 namespace SeqCli.EndToEnd.Node;
 
-[CliTestCase(MinimumApiVersion = "2021.3.6410")]
+[CliTestCase]
 public class NodeDemoteTestCase: ICliTestCase
 {
     public Task ExecuteAsync(SeqConnection connection, ILogger logger, CliCommandRunner runner)

test/SeqCli.EndToEnd/Node/NodeHealthTestCase.cs

@@ -6,14 +6,14 @@
 
 namespace SeqCli.EndToEnd.Node;
 
-[CliTestCase(MinimumApiVersion = "2021.3.6410")]
+[CliTestCase]
 public class NodeHealthTestCase: ICliTestCase
 {
     public Task ExecuteAsync(SeqConnection connection, ILogger logger, CliCommandRunner runner)
     {
         var exit = runner.Exec("node health");
         Assert.Equal(0, exit);
-        Assert.StartsWith("HTTP 1.1 200 OK", runner.LastRunProcess!.Output);
+        Assert.StartsWith("{\"status\":", runner.LastRunProcess!.Output);
         return Task.CompletedTask;
     }
 }

test/SeqCli.EndToEnd/Node/NodeListTestCase.cs

@@ -6,7 +6,7 @@
 
 namespace SeqCli.EndToEnd.Node;
 
-[CliTestCase(MinimumApiVersion = "2021.3.6410")]
+[CliTestCase]
 public class NodeListTestCase: ICliTestCase
 {
     public Task ExecuteAsync(SeqConnection connection, ILogger logger, CliCommandRunner runner)