Ignore alert activity when exporting templates

Author: nblumhardt

src/SeqCli/Templates/Export/TemplateSetExporter.cs

@@ -43,6 +43,7 @@ public async Task ExportTemplateSet()
             templateValueMap.MapAsReferenceList<WorkspaceContentPart>(nameof(WorkspaceContentPart.DashboardIds));
             templateValueMap.MapAsReferenceList<WorkspaceContentPart>(nameof(WorkspaceContentPart.QueryIds));
             templateValueMap.MapAsReferenceList<WorkspaceContentPart>(nameof(WorkspaceContentPart.SignalIds));
+            templateValueMap.Ignore<AlertEntity>(nameof(AlertEntity.Activity));
 
             await ExportTemplates<SignalEntity>(
                 id => _connection.Signals.FindAsync(id),

src/SeqCli/Templates/Export/TemplateValueMap.cs

@@ -14,6 +14,7 @@ class TemplateValueMap
         readonly HashSet<PropertyInfo> _referenceProperties = new();
         readonly HashSet<PropertyInfo> _referenceListProperties = new();
         readonly Dictionary<PropertyInfo, string> _argProperties = new();
+        readonly HashSet<PropertyInfo> _ignoredProperties = new();
 
         static PropertyInfo GetProperty<T>(string propertyName) =>
             typeof(T).GetProperty(propertyName) ??
@@ -39,6 +40,11 @@ public void AddReferencedTemplate(string entityId, string name)
             _idToReferenceName.Add(entityId, name);
         }
 
+        public void Ignore<T>(string propertyName)
+        {
+            _ignoredProperties.Add(GetProperty<T>(propertyName));
+        }
+
         public bool TryGetRawValue(PropertyInfo pi, object? value, [MaybeNullWhen(false)] out string raw)
         {
             if (value is string s && _referenceProperties.Contains(pi) &&
@@ -72,6 +78,8 @@ public bool TryGetRawElement(PropertyInfo pi, object? elementValue, [MaybeNullWh
             return false;
         }
 
+        public bool IsIgnored(PropertyInfo pi) => _ignoredProperties.Contains(pi);
+
         static string FormatReference(string name)
         {
             var jsonStringName = JsonConvert.SerializeObject(name);

src/SeqCli/Templates/Export/TemplateWriter.cs

@@ -76,6 +76,9 @@ static async Task WriteObjectAsync(JsonWriter jw, object o, TemplateValueMap tem
 
             foreach (var (pi, v) in GetTemplateProperties(o))
             {
+                if (templateValueMap.IsIgnored(pi))
+                    continue;
+                
                 var pa = pi.GetCustomAttribute<JsonPropertyAttribute>();
                 if (pa?.DefaultValueHandling == DefaultValueHandling.Ignore &&
                     v == null || v as int? == 0 || v as decimal? == 0m || v as uint? == 0)

test/SeqCli.Tests/Templates/TemplateWriterTests.cs

@@ -15,6 +15,7 @@ class TestEntity : Entity
         public string Name { get; set; }
         public string ReferencedId { get; set; }
         public List<int> Numbers { get; set; }
+        public List<string> Strings { get; set; }
     }
 
     public class TemplateWriterTests
@@ -27,14 +28,16 @@ public async Task WritesTemplates()
                 Id = "test-stuff",
                 Name = "Test Stuff",
                 ReferencedId = "test-ref",
-                Numbers = new List<int> { 1, 2, 3 }
+                Numbers = new List<int> { 1, 2, 3 },
+                Strings = new List<string> { "test" }
             };
 
             const string referencedTemplateName = "Referenced";
 
             var tvm = new TemplateValueMap();
             tvm.AddReferencedTemplate(entity.ReferencedId, referencedTemplateName);
             tvm.MapAsReference<TestEntity>(nameof(TestEntity.ReferencedId));
+            tvm.Ignore<TestEntity>(nameof(TestEntity.Strings));
 
             var content = new StringWriter();
             await TemplateWriter.WriteTemplateAsync(content, entity, tvm);