Retain the old file read/init behavior for now

Author: nblumhardt

src/SeqCli/Cli/Commands/ConfigCommand.cs

@@ -52,13 +52,13 @@ protected override Task<int> Run()
                 {
                     verb = "clear";
                     KeyValueSettings.Clear(config, _key);
-                    SeqCliConfig.Write(config, RuntimeConfigurationLoader.DefaultConfigFilename);
+                    SeqCliConfig.WriteToFile(config, RuntimeConfigurationLoader.DefaultConfigFilename);
                 }
                 else if (_value != null)
                 {
                     verb = "update";
                     KeyValueSettings.Set(config, _key, _value);
-                    SeqCliConfig.Write(config, RuntimeConfigurationLoader.DefaultConfigFilename);
+                    SeqCliConfig.WriteToFile(config, RuntimeConfigurationLoader.DefaultConfigFilename);
                 }
                 else
                 {

src/SeqCli/Cli/Commands/Profile/CreateCommand.cs

@@ -50,7 +50,7 @@ int RunSync()
         {
             var config = SeqCliConfig.ReadFromFile(RuntimeConfigurationLoader.DefaultConfigFilename);
             config.Profiles[_name] = new SeqCliConnectionConfig { ServerUrl = _url, ApiKey = _apiKey };
-            SeqCliConfig.Write(config, RuntimeConfigurationLoader.DefaultConfigFilename);
+            SeqCliConfig.WriteToFile(config, RuntimeConfigurationLoader.DefaultConfigFilename);
             return 0;
         }
         catch (Exception ex)

src/SeqCli/Cli/Commands/Profile/RemoveCommand.cs

@@ -41,7 +41,7 @@ int RunSync()
                 return 1;
             }
 
-            SeqCliConfig.Write(config, RuntimeConfigurationLoader.DefaultConfigFilename);
+            SeqCliConfig.WriteToFile(config, RuntimeConfigurationLoader.DefaultConfigFilename);
 
             return 0;
         }

src/SeqCli/Config/RuntimeConfigurationLoader.cs

@@ -16,9 +16,7 @@ static class RuntimeConfigurationLoader
     /// </summary>
     public static SeqCliConfig Load()
     {
-        var config = File.Exists(DefaultConfigFilename) ?
-            SeqCliConfig.ReadFromFile(DefaultConfigFilename) :
-            new SeqCliConfig();
+        var config = SeqCliConfig.ReadFromFile(DefaultConfigFilename);
 
         EnvironmentOverrides.Apply(DefaultEnvironmentVariablePrefix, config);
 

src/SeqCli/Config/SeqCliConfig.cs

@@ -40,15 +40,18 @@ class SeqCliConfig
     /// This method is typically used when editing/manipulating the configuration file itself. To read and use the
     /// configuration at runtime, see <see cref="RuntimeConfigurationLoader.Load"/>.
     /// </summary>
+    /// <remarks>If <paramref name="filename"/> does not exist, a new default configuration will be returned.</remarks>
     public static SeqCliConfig ReadFromFile(string filename)
     {
+        if (!File.Exists(filename))
+            return new SeqCliConfig();
+
         var content = File.ReadAllText(filename);
         return JsonConvert.DeserializeObject<SeqCliConfig>(content, SerializerSettings)!;
     }
 
-    public static void Write(SeqCliConfig data, string filename)
+    public static void WriteToFile(SeqCliConfig data, string filename)
     {
-        if (data == null) throw new ArgumentNullException(nameof(data));
         if (!data._exportable)
             throw new InvalidOperationException("The provided configuration is not exportable.");